test: run test on Node.js 22

[fengmk2]

Summary by CodeRabbit

• Chores
  • Updated the Node.js version support to include version 22 for enhanced compatibility and performance.

[coderabbitai]

Walkthrough

The changes encompass updating the Node.js version in the GitHub Actions workflow to include version 22, aligning with the latest developments in the Node.js ecosystem. Additionally, minor adjustments were made in test files to refine logging and debugging outputs, enhancing code clarity and maintenance.

Changes

File Path	Change Summary
.github/workflows/nodejs.yml	Updated Node.js version to include 22; adjusted installation command.
test/index.test.ts	Commented out console.log statements for specific functions.
test/keep-alive-header.test.ts	Commented out console.log statements for request and response stats.

Poem

🐇💻
In the land of code and wire,
A rabbit hopped, its dreams aspire.
To tweak the nodes, a change so small,
Version twenty-two, standing tall.
With each push, the future bright,
Code hops on through day and night. 🌟

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 50df506 and 9bcfed8.

Files selected for processing (2)

• test/index.test.ts (2 hunks)
• test/keep-alive-header.test.ts (3 hunks)

Files skipped from review due to trivial changes (1)

• test/index.test.ts

Additional Context Used

GitHub Check Runs (1)

Node.js / Test (macos-latest, 22) failure (2)

test/keep-alive-header.test.ts: [failure] 38-38: test/keep-alive-header.test.ts > keep-alive-header.test.ts > should handle Keep-Alive header and not throw reset error on 1s keepalive agent
AssertionError: Expected values to be strictly equal:

0 !== 1

• Expected

• Received

• 1

• 0

❯ test/keep-alive-header.test.ts:38:20

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Out of diff range and nitpick comments (5)

test/keep-alive-header.test.ts (5)

34-34: Consider re-enabling or replacing the commented-out debug log.

The commented-out debug log at line 34 might be useful for understanding the state of the httpClient after a request. If it's not necessary during normal test runs, consider enabling it conditionally based on an environment variable or a debug flag.

---

Line range hint 38-38: Address the assertion failure.

The assertion at line 38 fails because the expected and actual values do not match. This might indicate an issue with the test setup or the behavior of the httpClient. It's crucial to investigate why the pending count is not as expected.

---

43-43: Consider re-enabling or replacing the commented-out debug log.

The commented-out debug log at line 43 could provide valuable insights into the state of the httpClient after receiving a response. Similar to the previous comment, consider enabling it conditionally to aid in debugging without cluttering normal test output.

---

132-132: Consider re-enabling or replacing the commented-out debug log.

The commented-out debug log at line 132 could be crucial for understanding the state of the httpClient before a sleep operation. This information might be critical when diagnosing issues related to state changes during the sleep period.

---

137-137: Consider re-enabling or replacing the commented-out debug log.

The commented-out debug log at line 137 provides insights into the state of the httpClient after a sleep operation. This could be particularly useful for tracking changes in the connection pool over time, which is critical for tests involving keep-alive behavior.

[fengmk2]

merge into #511