Skip to content

fix(changesets): remove peer deps - #1050

Open
avivkeller wants to merge 1 commit into
mainfrom
peer
Open

fix(changesets): remove peer deps#1050
avivkeller wants to merge 1 commit into
mainfrom
peer

Conversation

@avivkeller

Copy link
Copy Markdown
Member

As titled, a fix for changesets

@avivkeller
avivkeller requested a review from a team as a code owner August 22, 2026 16:54
@vercel

vercel Bot commented Aug 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Error Error Aug 23, 2026 4:11pm

Request Review

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 22, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
f094fcb 2026-08-23T16:11:26.378Z View logs ↗
  • Build: Failed ❌

View logs ↗
8065f0c 2026-08-23T16:14:27.875Z View logs ↗

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 23.1% slower (1.04 s → 1.28 s)
  • Peak memory: 2.3% lower (366.38 MB → 358.09 MB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 6.3% slower (19.90 s → 21.15 s)
  • Peak memory: 5.6% higher (2.26 GB → 2.39 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 8.1% slower (7.81 s → 8.44 s)
  • Peak memory: 0.6% higher (1.79 GB → 1.80 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 2.4% faster (8.49 s → 8.29 s)
  • Peak memory: 2.9% higher (1.78 GB → 1.84 GB)

orama-db Generator

Performance estimate (single CI run)

  • Generation time: 14.3% slower (8.61 s → 9.84 s)
  • Peak memory: 0.5% lower (1.81 GB → 1.80 GB)

web Generator

Output size: 1 file changed · net +210.00 B

File size details
File Main PR Change
all.html 31.91 MB 31.91 MB +210.00 B (+0.0%)

Performance estimate (single CI run)

  • Generation time: 1.0% slower (85.12 s → 85.95 s)
  • Peak memory: 1.7% higher (5.23 GB → 5.32 GB)

Comment thread packages/core/package.json
Comment thread packages/core/package.json
@avivkeller avivkeller changed the title fix(changesets): dont major update peer deps fix(changesets): remove peer deps Aug 23, 2026
@avivkeller

Copy link
Copy Markdown
Member Author

We need peer deps since without them, certain package managers (e.g. pnpm) will not link the dependencies to the core package.

@ovflowd

ovflowd commented Aug 23, 2026

Copy link
Copy Markdown
Member

We need peer deps since without them, certain package managers (e.g. pnpm) will not link the dependencies to the core package.

But shouldn't be the opposite? the other packages peerDepending on the core package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants