Skip to content

http2: optimize final response writes - #64989

Closed
GetThatCookie wants to merge 1 commit into
nodejs:mainfrom
GetThatCookie:pr64980_http2
Closed

http2: optimize final response writes#64989
GetThatCookie wants to merge 1 commit into
nodejs:mainfrom
GetThatCookie:pr64980_http2

Conversation

@GetThatCookie

Copy link
Copy Markdown
Contributor

This PR is one of four focused changes split out of #64980 following review
feedback.

The full context, rationale, related work, benchmarks, and validation details
are documented there.

The AI-assistance disclosure in #64980 applies to this split PR as well.

Signed-off-by: GetThatCookie <NimmenKeks@gmx.de>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net
  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Aug 3, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.27%. Comparing base (f00fb75) to head (bea785c).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/http2/compat.js 79.31% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64989   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         762      762           
  Lines      247534   247556   +22     
  Branches    46694    46693    -1     
=======================================
+ Hits       223457   223486   +29     
+ Misses      15529    15505   -24     
- Partials     8548     8565   +17     
Files with missing lines Coverage Δ
lib/internal/http2/compat.js 96.71% <79.31%> (-0.51%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GetThatCookie

Copy link
Copy Markdown
Contributor Author

Closing this because the isolated HTTP/2 change did not show a meaningful end-to-end benefit.

@GetThatCookie
GetThatCookie deleted the pr64980_http2 branch August 24, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants