Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting and best practices #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Formatting and best practices #1

wants to merge 5 commits into from

Conversation

andrlime
Copy link
Collaborator

  1. You didn't use logo.svg after importing it, might as well remove because it's pointless
  2. In background it was <div ... > with a space at the end and in foreground is was <div ...> with no space, this should probably be consistent otherwise it looks weird
  3. Component files should be capitalized, so background should be Background

@echavemann
Copy link
Member

look at andrew caring about the applicant experience!!

egelja
egelja approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@egelja egelja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egelja egelja egelja approved these changes

@hongZhou443 hongZhou443 Awaiting requested review from hongZhou443

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrlime @echavemann @egelja