Removed type from market order

northwesternfintech · Oct 1, 2023 · be31a1c · be31a1c
1 parent 1e46266
commit be31a1c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/src/mock_api/mock_api.cpp b/src/mock_api/mock_api.cpp
@@ -3,21 +3,19 @@
 namespace nutc {
 namespace mock_api {
 std::function<
-    bool(const std::string&, const std::string&, const std::string&, float, float)>
+    bool(const std::string&, const std::string&, float, float)>
 
 getMarketFunc()
 {
     return [](const std::string& side,
-              const std::string& type,
               const std::string& ticker,
               float quantity,
               float price) {
         log_i(
             mock_api,
-            "Mock API: Placing order side {} type {} ticker {} quantity {} price "
+            "Mock API: Placing order side {} ticker {} quantity {} price "
             "{}",
             side,
-            type,
             ticker,
             quantity,
             price

diff --git a/src/mock_api/mock_api.hpp b/src/mock_api/mock_api.hpp
@@ -9,7 +9,7 @@ namespace nutc {
 namespace mock_api {
 
 std::function<
-    bool(const std::string&, const std::string&, const std::string&, float, float)>
+    bool(const std::string&, const std::string&, float, float)>
 getMarketFunc();
 }
 } // namespace nutc
diff --git a/src/pywrapper/runtime.cpp b/src/pywrapper/runtime.cpp
@@ -8,7 +8,7 @@ namespace pywrapper {
 bool
 create_api_module(
     std::function<
-        bool(const std::string&, const std::string&, const std::string&, float, float)>
+        bool(const std::string&, const std::string&, float, float)>
         publish_market_order
 )
 {
@@ -24,8 +24,8 @@ create_api_module(
 
         py::exec(R"(import nutc_api)");
         py::exec(R"(
-        def place_market_order(side, type, ticker, quantity, price):
-            nutc_api.publish_market_order(side, type, ticker, quantity, price)
+        def place_market_order(side, ticker, quantity, price):
+            nutc_api.publish_market_order(side, ticker, quantity, price)
     )");
     } catch (const std::exception& e) {
         return false;

diff --git a/src/pywrapper/runtime.hpp b/src/pywrapper/runtime.hpp
@@ -12,7 +12,7 @@ namespace nutc {
 namespace pywrapper {
 bool create_api_module(
     std::function<
-        bool(const std::string&, const std::string&, const std::string&, float, float)>
+        bool(const std::string&, const std::string&, float, float)>
         publish_market_order
 );
 std::optional<std::string> import_py_code(const std::string& code);