Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests to gtest #7

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Convert tests to gtest #7

merged 2 commits into from
Jul 18, 2023

Conversation

egelja
Copy link
Member

@egelja egelja commented Jul 18, 2023

As requested by @echavemann.

@egelja egelja requested a review from a team as a code owner July 18, 2023 19:39
echavemann
echavemann previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@echavemann echavemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct.

@egelja egelja requested a review from stevenewald as a code owner July 18, 2023 19:41
@egelja egelja requested a review from echavemann July 18, 2023 19:53
echavemann
echavemann approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@echavemann echavemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible coverage !

@egelja egelja merged commit 4d736d0 into main Jul 18, 2023
4 of 5 checks passed
@egelja egelja deleted the egelja/gtest branch July 18, 2023 20:03
@egelja egelja restored the egelja/gtest branch July 18, 2023 20:03
@egelja egelja deleted the egelja/gtest branch July 18, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echavemann echavemann echavemann approved these changes

@stevenewald stevenewald Awaiting requested review from stevenewald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egelja @echavemann