Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mautic-zendesk] Uses pino as a standard logger and improves form_entries query #61 #68

Merged
merged 14 commits into from
Jun 2, 2021
Merged

[mautic-zendesk] Uses pino as a standard logger and improves form_entries query #61 #68

merged 14 commits into from
Jun 2, 2021

Conversation

vivianedias
Copy link
Contributor

@vivianedias vivianedias commented May 16, 2021 •
edited
Loading

  • adds pino as a standard logger
  • conects with apm
    • sets custom contexts to improve future debugging
    • sets user context for every req
  • improves form_entries graphql query by searching with email (before we fetched all form_entries from certain widgets)
  • gets registration number from form_entry and sets again if there was none from mautic form (this prevents null registration number)

Solves #61

@vivianedias vivianedias changed the title [mautic-zendesk] Uses pino as a standard logger #61 [WIP] [mautic-zendesk] Uses pino as a standard logger #61 May 17, 2021
Viviane Dias added 5 commits May 24, 2021 10:00
feat(mautic-zendesk): adds more context to logs and captures errors
3f0d12e
feat(mautic-zendesk): adds more context to volunteer integration steps
1ad3075
fix(mautic-zendesk): makes apm an optional param and captures req bod…
83ec080 
…y if there were errors on the req
feat(mautic-zendesk): fetches form_entries with email filter
1cc6289
feat(mautic-zendesk): records registration_number again
58c3fcd 
In some mautic forms we dont ask for registration_number and assume that
the initial integration with zendesk got those info from the form_entry
and saved in the user.

Due to several problemas with this particular data, now we parse
registration_number from the form_entriy and save it in case the form
didnt have any. If the form has that field we just save that value, if
it doesnt we use the registration_number from the form_entry.
@vivianedias vivianedias changed the title [WIP] [mautic-zendesk] Uses pino as a standard logger #61 [mautic-zendesk] Uses pino as a standard logger #61 May 30, 2021
@vivianedias vivianedias changed the title [mautic-zendesk] Uses pino as a standard logger #61 [mautic-zendesk] Uses pino as a standard logger and improves form_entries query #61 May 30, 2021
@vivianedias vivianedias merged commit 1c81326 into main Jun 2, 2021
@vivianedias vivianedias deleted the feature/pino-log-mautic-zendesk branch June 2, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpirola lpirola lpirola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivianedias @lpirola @dieh