-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mautic-zendesk] Uses pino as a standard logger and improves form_entries query #61 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivianedias
changed the title
[mautic-zendesk] Uses pino as a standard logger #61
[WIP] [mautic-zendesk] Uses pino as a standard logger #61
May 17, 2021
…y if there were errors on the req
In some mautic forms we dont ask for registration_number and assume that the initial integration with zendesk got those info from the form_entry and saved in the user. Due to several problemas with this particular data, now we parse registration_number from the form_entriy and save it in case the form didnt have any. If the form has that field we just save that value, if it doesnt we use the registration_number from the form_entry.
vivianedias
changed the title
[WIP] [mautic-zendesk] Uses pino as a standard logger #61
[mautic-zendesk] Uses pino as a standard logger #61
May 30, 2021
vivianedias
changed the title
[mautic-zendesk] Uses pino as a standard logger #61
[mautic-zendesk] Uses pino as a standard logger and improves form_entries query #61
May 30, 2021
lpirola
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #61