Bug fix for #186 #188
Open
Bug fix for #186 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy support does not work when the IP address of the proxy server is used instead of the hostname. This issue was introduced when adding support for authentication proxies.
The previous commit for notnoop#186 does not work on any version before JDK 1.7.
|
HEllo @vijaygos ! thanks for your patch, do you mind adding a test-case for this to: Thanks! |
|
Sorry. Just checked back on the request. I ran some UT with the commented out code in TlsTunnelBuilderTest.java in my infrastructure. But, I'll work on something generic right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.