-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ripe v3 dao fork front end #745
Merged
solimander
merged 361 commits into
nounsDAO:master
from
ripe0x:ripe-v3-dao-fork-front-end
Aug 1, 2023
Merged
ripe v3 dao fork front end #745
solimander
merged 361 commits into
nounsDAO:master
from
ripe0x:ripe-v3-dao-fork-front-end
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functions and subgraph calls for fork data
…ing first noun to start fork
…gnature, added multiple step process indicators
davidbrai
changed the base branch from
verbs-dao-v3-contract-size-libraries-design
to
verbs-dao-v3-dao-split
June 30, 2023 08:33
…ipe-v3-dao-fork-front-end
Closed
eladmallel
reviewed
Jul 27, 2023
solimander
reviewed
Jul 28, 2023
eladmallel
reviewed
Jul 28, 2023
davidbrai
reviewed
Jul 28, 2023
davidbrai
reviewed
Jul 28, 2023
eladmallel
reviewed
Jul 28, 2023
solimander
reviewed
Jul 28, 2023
packages/nouns-webapp/src/components/CandidateSponsors/SignatureForm.tsx
Outdated
Show resolved
Hide resolved
eladmallel
reviewed
Jul 28, 2023
eladmallel
reviewed
Jul 28, 2023
solimander
reviewed
Jul 28, 2023
…ding state for candidates list
solimander
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Edit
button on the proposal view alongside theCancel
button.Examples:
Examples:
Examples:
Ends
element to give additional context.Examples (using screenshots because the state is time-based):
/forks
page that lists all fork instances, and a/fork/[id]
page, add nouns to escrow/fork with reason, withdraw from escrow, and empty, escrow, forking, forked states.Examples:
Upgrade Plan
Once the v3 data contract has been deployed and added to subgraph, this code works with v2 and v3 contracts, with an auto-detect hook that toggles features based on the contract versions. So once the v3 contracts are updated, the UI will update automatically. If v3 features need to be hidden post-upgrade, they can be toggled off in the config.