Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ripe v3 dao fork front end #745

Merged
merged 361 commits into from
Aug 1, 2023

Conversation

ripe0x
Copy link
Contributor

@ripe0x ripe0x commented Jun 30, 2023

Change summary

  1. Proposal editing: UI updates to allow proposers to update proposals while within the updatablePeriod. UI updates include the addition of a "Version X" element below the title, proposal editing view, a updatable proposal pill, and a new proposal history page for each proposal version. If a proposal is updatable, the proposer will see an Edit button on the proposal view alongside the Cancel button.
    Examples:
  2. Propose by signature: Referenced as candidates in the UI. Anyone can submit a proposal candidate (non-voters pay a fee), which can then be sponsored by nouns voters. Like proposals, candidates are also editable. UI updates include candidate proposal view, candidate editing view candidate history, candidate sponsoring flow, candidate proposal flow.
    Examples:
  3. Feedback on proposals and candidates: nouns voters can submit written feedback and a voting direction on updatable proposals and proposal candidates. UI updates include adding a sidebar to proposals to hold the feedback component, creating states for viewing and submitting feedback onchain.
    Examples:
  4. Objection-only period: as described in DAO V3: Nouns Fork, propose by sigs, updatable period, objection period, snapshot votes at vote start #706, UI updates include the addition of a new alert bar during the period. once the objection period has been triggered, but before the period starts, a short description appears below the Ends element to give additional context.
    Examples (using screenshots because the state is time-based):
    image
  5. Votes Snapshot After Voting Delay: as described in DAO V3: Nouns Fork, propose by sigs, updatable period, objection period, snapshot votes at vote start #706.
  6. Nouns Fork: UI additions include a new /forks page that lists all fork instances, and a /fork/[id] page, add nouns to escrow/fork with reason, withdraw from escrow, and empty, escrow, forking, forked states.
    Examples:
  7. Global nav: added a dropdown to the DAO nav item that exposes Proposals, Candidates, and Fork.
  8. Feature toggles: The v3 features can be toggled on/off using the config here. As an extra measure, there is also a hook implemented that auto-checks to see if the site is connected to v3 contracts, and only exposes the v3 features if that's the case.

Upgrade Plan

Once the v3 data contract has been deployed and added to subgraph, this code works with v2 and v3 contracts, with an auto-detect hook that toggles features based on the contract versions. So once the v3 contracts are updated, the UI will update automatically. If v3 features need to be hidden post-upgrade, they can be toggled off in the config.

ripe0x added 27 commits June 23, 2023 19:27
…gnature, added multiple step process indicators
@davidbrai davidbrai changed the base branch from verbs-dao-v3-contract-size-libraries-design to verbs-dao-v3-dao-split June 30, 2023 08:33
@ripe0x ripe0x mentioned this pull request Jun 30, 2023
@ripe0x ripe0x marked this pull request as ready for review July 27, 2023 22:49
@solimander solimander changed the base branch from master to verbs-dao-v3-dao-split July 28, 2023 15:07
netlify.toml Outdated Show resolved Hide resolved
@eladmallel eladmallel changed the base branch from verbs-dao-v3-dao-split to master July 31, 2023 15:23
@solimander solimander merged commit f44766b into nounsDAO:master Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants