[terrain] use slow math

Cargo.toml

@@ -13,7 +13,6 @@ clap       = { version = "4.4.2", features = ["derive"] }
 criterion  = { version = "0.5", features = ["html_reports"] }
 dashmap    = "5.5.3"
 env_logger = "0.10.0"
-fast-math  = "0.1.1"
 geo        = "0.26.0"
 itertools  = "0.11.0"
 log        = "0.4.20"

terrain/Cargo.toml

@@ -5,7 +5,6 @@ edition = "2021"
 
 [dependencies]
 dashmap    = { workspace = true }
-fast-math  = { workspace = true }
 geo        = { workspace = true }
 log        = { workspace = true }
 nasadem    = { path = "../nasadem" }

terrain/src/math.rs

@@ -41,7 +41,7 @@ impl<T: CoordFloat> HaversineIter<T> {
     }
 }
 
-impl<T: CoordFloat + Atan2 + AsPrimitive<usize>> Iterator for HaversineIter<T> {
+impl<T: CoordFloat + AsPrimitive<usize>> Iterator for HaversineIter<T> {
     type Item = Point<T>;
 
     fn next(&mut self) -> Option<Self::Item> {
@@ -60,7 +60,7 @@ impl<T: CoordFloat + Atan2 + AsPrimitive<usize>> Iterator for HaversineIter<T> {
     }
 }
 
-impl<T: CoordFloat + Atan2 + AsPrimitive<usize>> ExactSizeIterator for HaversineIter<T> {
+impl<T: CoordFloat + AsPrimitive<usize>> ExactSizeIterator for HaversineIter<T> {
     fn len(&self) -> usize {
         self.total_points.as_() - self.current_point.as_()
     }
@@ -80,7 +80,7 @@ struct HaversineParams<T> {
 #[allow(clippy::many_single_char_names)]
 fn get_point<T>(params: &HaversineParams<T>, f: T) -> Point<T>
 where
-    T: CoordFloat + Atan2,
+    T: CoordFloat,
 {
     let one = T::one();
 
@@ -101,8 +101,8 @@ where
     let y = a * p + b * q;
     let z = a * r + b * s;
 
-    let lat = Atan2::atan2(z, x.hypot(y));
-    let lon = Atan2::atan2(y, x);
+    let lat = z.atan2(x.hypot(y));
+    let lon = y.atan2(x);
 
     Point::new(lon.to_degrees(), lat.to_degrees())
 }
@@ -147,22 +147,6 @@ where
     }
 }
 
-pub trait Atan2 {
-    fn atan2(lhs: Self, rhs: Self) -> Self;
-}
-
-impl Atan2 for f32 {
-    fn atan2(lhs: Self, rhs: Self) -> Self {
-        fast_math::atan2(lhs, rhs)
-    }
-}
-
-impl Atan2 for f64 {
-    fn atan2(lhs: Self, rhs: Self) -> Self {
-        lhs.atan2(rhs)
-    }
-}
-
 /// Returns the up/down angle (in radians) from a to b.
 pub fn elevation_angle<T>(start_elev_m: T, distance_m: T, end_elev_m: T) -> T
 where

terrain/src/profile.rs

@@ -1,5 +1,5 @@
 use crate::{
-    math::{elevation_angle, linspace, Atan2, HaversineIter},
+    math::{elevation_angle, linspace, HaversineIter},
     TerrainError, Tiles,
 };
 use geo::{
@@ -120,7 +120,7 @@ where
 
     pub fn build(&self, tiles: &Tiles) -> Result<Profile<C>, TerrainError>
     where
-        C: Atan2 + FloatConst + AsPrimitive<usize>,
+        C: FloatConst + AsPrimitive<usize>,
     {
         let start = self.start.ok_or(TerrainError::Builder("start"))?;
         let max_step_m = self.max_step_m.ok_or(TerrainError::Builder("max_step"))?;