Fix/parse tree bug #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging all changes for BlaBla V0.2 Release
Release BlaBla V0.2.2
|
Raphael Lenain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jackanth
requested changes
Jan 26, 2021
blabla/utils/utils.py
Outdated
| from nltk.tree import Tree | ||
|
|
||
|
|
||
| def get_nltk_tree(parse_tree) -> Tree: |
There was a problem hiding this comment.
Are we doing typing or not? Pick a lane buddy.
| return Tree( | ||
| parse_tree.value, | ||
| [get_nltk_tree(child) for child in parse_tree.child] | ||
| ) if parse_tree.child else parse_tree.value |
setup.py
Outdated
| "stanza==1.0.0", | ||
| "stanza>=1.1.0", |
There was a problem hiding this comment.
We discussed pinning only major versions. What's the rationale here? Consider changing all to major version only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that we do not accept pull requests for the
masterbranch. You should raise new PRs for thedevbranch only.See our contributing guide for details.
Please include the following details in your pull request to make the reviewer's job easier.
Please note that before your pull request will be merged, you must sign our Contributor License Agreement (CLA). Instructions on how to do this will be automatically commented on the PR once you make it.