fix: PhyloDistance bugs - #83
Open
ahl27 wants to merge 3 commits into
Open
Conversation
This was due to the greedy matching scheme originally implemented, which can cause suboptimal partitions to be paired and return a nonzero distance. Instead, we'll just revert to using the original Hungarian algorithm here for globally optimal pairing (at the expense of computational efficiency). Also updates some math to correct for floating point precision issues. Original greedy matching is maintained via new `Exact` argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method="CI"now defaults to using a Hungarian algorithm for partition matching instead of greedy matching. This resolves issues where comparing a tree to itself would return nonzero distance.Exactargument (defaultTRUE) to enable the Hungarian algorithm. SettingExact=FALSEuses the old greedy matching schema for backwards compatibility.