clippy #1774
fafhrd91Annotations
20 warnings
|
Rustfmt (stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rustfmt (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
this `RefCell` reference is held across an `await` point:
ntex-glommio/src/io.rs#L514
warning: this `RefCell` reference is held across an `await` point
--> ntex-glommio/src/io.rs:514:41
|
514 | ... io.0.borrow()
| ^^^^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> ntex-glommio/src/io.rs:513:67
|
513 | ... let fut = Box::pin(async move {
| _____________________________________________________^
514 | | ... io.0.borrow()
515 | | ... .shutdown(std::net::Shutdown::Write)
516 | | ... .await
517 | | ... });
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
|
|
this `RefCell` reference is held across an `await` point:
ntex-glommio/src/io.rs#L206
warning: this `RefCell` reference is held across an `await` point
--> ntex-glommio/src/io.rs:206:41
|
206 | ... io.0.borrow()
| ^^^^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> ntex-glommio/src/io.rs:205:67
|
205 | ... let fut = Box::pin(async move {
| _____________________________________________________^
206 | | ... io.0.borrow()
207 | | ... .shutdown(std::net::Shutdown::Write)
208 | | ... .await
209 | | ... });
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
= note: `#[warn(clippy::await_holding_refcell_ref)]` on by default
|
|
variable does not need to be mutable:
ntex-glommio/src/io.rs#L444
warning: variable does not need to be mutable
--> ntex-glommio/src/io.rs:444:13
|
444 | let mut this = self.as_mut().get_mut();
| ----^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
ntex-glommio/src/io.rs#L136
warning: variable does not need to be mutable
--> ntex-glommio/src/io.rs:136:13
|
136 | let mut this = self.as_mut().get_mut();
| ----^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
ntex-rt/src/lib.rs#L145
warning: very complex type used. Consider factoring parts into `type` definitions
--> ntex-rt/src/lib.rs:145:13
|
145 | Either<task::JoinHandle<T>, Pin<Box<dyn Future<Output = Result<T, Canceled>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
this `RefCell` reference is held across an `await` point:
ntex-glommio/src/io.rs#L514
warning: this `RefCell` reference is held across an `await` point
--> ntex-glommio/src/io.rs:514:41
|
514 | ... io.0.borrow()
| ^^^^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> ntex-glommio/src/io.rs:513:67
|
513 | ... let fut = Box::pin(async move {
| _____________________________________________________^
514 | | ... io.0.borrow()
515 | | ... .shutdown(std::net::Shutdown::Write)
516 | | ... .await
517 | | ... });
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
|
|
this `RefCell` reference is held across an `await` point:
ntex-glommio/src/io.rs#L206
warning: this `RefCell` reference is held across an `await` point
--> ntex-glommio/src/io.rs:206:41
|
206 | ... io.0.borrow()
| ^^^^^^^^^^^^^
|
= help: ensure the reference is dropped before calling `await`
note: these are all the `await` points this reference is held through
--> ntex-glommio/src/io.rs:205:67
|
205 | ... let fut = Box::pin(async move {
| _____________________________________________________^
206 | | ... io.0.borrow()
207 | | ... .shutdown(std::net::Shutdown::Write)
208 | | ... .await
209 | | ... });
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
= note: `#[warn(clippy::await_holding_refcell_ref)]` on by default
|
|
variable does not need to be mutable:
ntex-glommio/src/io.rs#L444
warning: variable does not need to be mutable
--> ntex-glommio/src/io.rs:444:13
|
444 | let mut this = self.as_mut().get_mut();
| ----^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
ntex-glommio/src/io.rs#L136
warning: variable does not need to be mutable
--> ntex-glommio/src/io.rs:136:13
|
136 | let mut this = self.as_mut().get_mut();
| ----^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
ntex-rt/src/lib.rs#L145
warning: very complex type used. Consider factoring parts into `type` definitions
--> ntex-rt/src/lib.rs:145:13
|
145 | Either<task::JoinHandle<T>, Pin<Box<dyn Future<Output = Result<T, Canceled>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|