Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator shouldn't implement IEncryptionAuthorizer logic #195

Open
cygnusv opened this issue Nov 18, 2023 · 1 comment
Open

Coordinator shouldn't implement IEncryptionAuthorizer logic #195

cygnusv opened this issue Nov 18, 2023 · 1 comment

Comments

@cygnusv
Copy link
Member

cygnusv commented Nov 18, 2023

Currently, Coordinator includes a function isEncryptionAuthorized that calls the access controller and nodes use it. Instead, we should remove this function, and nodes should be capable of resolving the access controller contract and contact it directly

@cygnusv
Copy link
Member Author

cygnusv commented Jun 28, 2024

Current decision is:

  • Leave this method in the contract, with a deprecation note.
  • Remove related endpoints in the nucypher client and include this change in the next release
  • Remove contract method only when we have assurance that the vast majority of nodes are running the next release or newer, and/or there's a mechanism to penalize nodes running outdated versions (see [WIP] Peer Snitching Contract #248)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant