Follow up PR: Removes BetaProgramInitiator, Global is Global, return backward compatibility #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzotova
changed the title
vzotova
requested review from
arjunhassard,
cygnusv,
theref,
derekpierre and
manumonti
cygnusv
approved these changes
Jul 1, 2024
| @@ -549,6 +543,16 @@ contract Coordinator is Initializable, AccessControlDefaultAdminRulesUpgradeable | |||
| return found; | |||
| } | |||
|
|
|||
| function isEncryptionAuthorized( | |||
There was a problem hiding this comment.
We should add a deprecation notice comment, with a link to #195
derekpierre
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
🎸 .
Compatibility with v7.3.0 was checked via nucypher/nucypher#3516
derekpierre
reviewed
Jul 2, 2024
| @@ -144,6 +143,10 @@ contract Coordinator is Initializable, AccessControlDefaultAdminRulesUpgradeable | |||
| return rituals[ritualId].accessController; | |||
| } | |||
|
|
|||
| function getFeeModel(uint32 ritualId) external view returns (IFeeModel) { | |||
| return rituals[ritualId].feeModel; | |||
There was a problem hiding this comment.
Something occurred to me. What happens to the existing rituals on mainnet that would not have a feeModel set in their Ritual struct? I guess those can't be extended? Other side effects?
There was a problem hiding this comment.
you are correct, old rituals can't be extended, I can create work around with FlatFeeRateModel as default for old rituals, wdyt?
There was a problem hiding this comment.
Opened #282, so let's move on with the PR.
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
Why it's needed:
Notes for reviewers:
I'd like to have help with naming new
GlobalAllowList(to be honest I'd not rename it at all)