General repo improvements #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vzotova
commented
Aug 7, 2023
•
vzotova
commented
- fancier event check
- solhint rules + hook
- prettier action + hook
vzotova
force-pushed
the
impr
branch
20 times, most recently
from
eef8522
to
2a57578
Compare
theref
approved these changes
Aug 21, 2023
| assert event["startTimestamp"] == start | ||
| assert event["endTimestamp"] == end | ||
| assert event["cost"] == fee | ||
| assert tx.events == [ |
There was a problem hiding this comment.
love this way of checking events 🚀
derekpierre
approved these changes
Aug 21, 2023
Comment on lines
+96
to
+97
| _precomputed.pointEZyCoord | ||
| ), // zE_y |
There was a problem hiding this comment.
Minor suggestion where I disagree with the linter.
Suggested change
| _precomputed.pointEZyCoord | |
| ), // zE_y | |
| _precomputed.pointEZyCoord // zE_y | |
| ), |
Some similar instances in later lines in this file.
There was a problem hiding this comment.
Looks like there is open issue in prettier for that prettier/prettier#807
We can add hack for ignoring this line for prettier or just accept that. Wdyt?
There was a problem hiding this comment.
Not a huge issue to me. If the hack is easy great, if it's more involved, don't bother. Up to you really.
| assert event["stakingProvider"] == staking_provider | ||
| assert event["fromAmount"] == 0 | ||
| assert event["toAmount"] == value | ||
| assert events == [ |
jMyles
reviewed
Aug 23, 2023
| uint256 constant PRECOMPUTED_DATA_SIZE = (20 * BIGNUM_SIZE) + 32 + 20 + 5; | ||
| uint256 internal constant BIGNUM_SIZE = 32; | ||
| uint256 internal constant POINT_SIZE = 33; | ||
| uint256 internal constant SIGNATURE_SIZE = 64; |
jMyles
reviewed
Aug 23, 2023
| assert event["fromAmount"] == value // 2 | ||
| assert event["toAmount"] == authorization | ||
| assert events == [ | ||
| taco_application.AuthorizationInvoluntaryDecreased( |
There was a problem hiding this comment.
badass. Love seeing events represented this way.
jMyles
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.