Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment Tools: Constructor Parameter and Artifact Tracking + Lynx Alpha 13 Deployent #119
Deployment Tools: Constructor Parameter and Artifact Tracking + Lynx Alpha 13 Deployent #119
Changes from all commits
ce01a48
e3788e5
6f5e137
e4c1bed
a52550c
6e9cd69
bc094a3
fdb4b08
88d80cb
9eab251
5ebb1ac
0e81248
faed0e5
740642c
ae49437
dfa87fe
d80c4d3
ea252bf
f35d14d
8399b1d
81018f4
c831402
c07d970
cfa0e7e
4c4cd00
733ea89
74a8f6f
115f33d
effda85
5081b40
fb996f2
7639c68
70c5f1a
ee5f5e3
442709a
0023a64
0a9d66b
ee531ec
3d75c81
924c81f
34c10fa
80b3de1
8ae98d0
dfc43ae
d60d2ad
4adf739
e702438
5bf960a
4ed3249
7e550c2
271652b
fa1f9ec
46b5d10
c6bdb17
e53f44b
12bc24e
48c43e5
3ab22f2
3b72f9c
d3c43e1
30876af
4e35100
a42d2df
c298816
2ca8ece
3298e71
bc20e6f
620cb85
a8cb1af
b0630f6
e1ff014
4a45b68
7bec4ef
67f67da
2cb01a0
5f968cf
45e3fa4
7b576a0
45004cd
9067693
e9dff3e
da3ca9c
e060df3
77eb119
70617af
1aa8b0a
580a221
c15126a
eeb9782
59c2b12
a82cd49
94f7c57
ca7e27a
0ad8570
34b5371
dc9ffe1
49dd3e5
53838f7
9b396e3
586f106
909cefc
60b9e59
682c3c0
9b6ee71
92541a7
2856a3b
6164188
b9d82dd
34b586b
1824eda
f403c5b
7688e60
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's important not to lose track of FxPortal official addresses. I guess we can add them in a later PR when we add the PolygonRoot and PolygonChild scripts, but mentioning just in case. Same for DAI contracts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heard. A few Ideas here: (1) let's tag the commit just before this PR, (2) make deployments scripts using this new methodology, and (3) perhaps we restore some of this section with further discussion as to not duplicate the effort presented in this PR's artifact tracking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new methodology is great. I was just pointing out to some addresses that we should collect later