Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #292 #293

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Fix for #292 #293

merged 4 commits into from
Jul 16, 2024

Conversation

vzotova
Copy link
Member

@vzotova vzotova commented Jul 15, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:
Fixes #292

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:
Based on #291

@vzotova vzotova self-assigned this Jul 15, 2024
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌.

I don't have a strong opinion about using require or conditional though.

@cygnusv cygnusv merged commit cc4d6f1 into nucypher:epic-subscription Jul 16, 2024
2 checks passed
@derekpierre derekpierre mentioned this pull request Aug 12, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants