ReimbursementPool on Lynx #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contract deployed in Amoy: https://amoy.polygonscan.com/address/0x53fe19093be1ac0136d33d91e01aba4aa381b87b |
KPrasch
approved these changes
Sep 3, 2024
derekpierre
reviewed
Sep 3, 2024
| /// with this reimbursment pool. Can be unauthorized by the | ||
| /// owner only. | ||
| /// @param _contract Authorized contract. | ||
| function unauthorize(address _contract) external onlyOwner { |
There was a problem hiding this comment.
Bit of a nitpick. I know this was copied from a Keep contract, but should this be deauthorize? We've used the authorize/deauthorize parlance in other areas.
Same comment for the event.
There was a problem hiding this comment.
I agree that there's a divergence wrt to staking contracts but this contract is not related to staking, and I'd prefer if we limit changes unless we really need them.
vzotova
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
ReimbursementPoolon CoordinatorIssues fixed/closed:
Why it's needed:
Notes for reviewers: