Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beefing up the Coordinator: Restrictions to initiator, ritual duration, fee model, automatic TX reimbursements, etc #86

Merged
merged 22 commits into from
Jun 29, 2023
Merged

Beefing up the Coordinator: Restrictions to initiator, ritual duration, fee model, automatic TX reimbursements, etc #86

merged 22 commits into from
Jun 29, 2023

Commits on Jun 9, 2023

  1. Introduce duration parameter for ritual creation 

    Optimize Ritual struct layout
    @cygnusv
    cygnusv committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    41f1634 View commit details
    Browse the repository at this point in the history

  2. Introduce Initiator role to gatekeep ritual initiation 

    Also replace contract owner for parameter administration role
    @cygnusv
    cygnusv committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e56c3ef View commit details
    Browse the repository at this point in the history

  3. Add authority field to Ritual. Can be different than initiator 

    Initiator is just the entity that calls initiateRitual(), needs to be authorized, and provides initial payment.
Authority is who controls ritual lifecycle going forward.
    @cygnusv
    cygnusv committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    f24fd29 View commit details
    Browse the repository at this point in the history

  4. Introduce interface for Fee Models 

    Fee Models dictate what's the cost for rituals
    @cygnusv
    cygnusv committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    deb7fcf View commit details
    Browse the repository at this point in the history

  5. Basic FlateRateFeeModel

    @cygnusv
    cygnusv committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b8492bf View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. EndRitual event only needs to track ritualID and the outcome

    @cygnusv
    cygnusv committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7ccae5b View commit details
    Browse the repository at this point in the history

  2. Use DEFAULT_ADMIN_ROLE as parameters admin 

    Also, changes AccessControl base contract for the more specific AccessControlDefaultAdminRules
    @cygnusv
    cygnusv committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    66e1f64 View commit details
    Browse the repository at this point in the history

  3. Function to make initiation public (no initiator allowlist) 

    Also, change isInitiationRegulated to isInitiationPublic
    @cygnusv
    cygnusv committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    64792c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Introduce feeModel parameter and use it to charge the proper ritual cost

    @cygnusv
    cygnusv committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    d13d287 View commit details
    Browse the repository at this point in the history

  2. Automatic reimbursing of ritual costs via ReimbursementPool 

    See https://github.com/keep-network/keep-core/blame/main/solidity/random-beacon/contracts/ReimbursementPool.sol
    @cygnusv
    cygnusv committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    ddb0847 View commit details
    Browse the repository at this point in the history

  3. Assorted fixes 

    Can't revoke INITIATOR_ROLE addresses since our AccessControl doesn't inherit from AccessControlEnumerable. It doesn't matter much anyway
    @cygnusv
    cygnusv committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    f11e8c4 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Bump OZ dependency to v4.9.1

    @cygnusv
    cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    486b893 View commit details
    Browse the repository at this point in the history

  2. Make transcript size a test constant 

    We may want to parametrize tests based on this
    @cygnusv
    cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    cf9e74a View commit details
    Browse the repository at this point in the history

  3. Deployment script for FlatRateFeeModel

    @cygnusv
    cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    55fa421 View commit details
    Browse the repository at this point in the history

  4. Add DAI deployment address for Polygon Mainnet and Mumbai 

    Add also previous StakeInfo deployment on Mumbai
    @cygnusv
    cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a896ed0 View commit details
    Browse the repository at this point in the history

  5. Add stakes reference to Fee Model contracts

    @cygnusv
    cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    85cc9c2 View commit details
    Browse the repository at this point in the history

  6. Single finalization logic when posting aggregations

    @cygnusv
    cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    d634394 View commit details
    Browse the repository at this point in the history

  7. Treat fees as pending until ritual is final 

    Either ritual is successful and fees can be used by the protocol, or ritual is failed and fees are refunded to initiator (consider partial refund)
    @cygnusv
    cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    02b93ed View commit details
    Browse the repository at this point in the history

  8. Ensure that provided decryption request static key by nodes is 42 byt… 

    …es long (as of nucypher-core v0.10.0).
    @derekpierre @cygnusv
    derekpierre authored and cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f819fac View commit details
    Browse the repository at this point in the history

  9. Adapt Coordinator tests to latest additions

    @cygnusv
    cygnusv committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    bc11d12 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Use SafeERC20 to interact with ERC20 tokens in Coordinator

    @cygnusv
    cygnusv committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    362891e View commit details
    Browse the repository at this point in the history

  2. Fixes StartRitual event. Simplifies ReimbursementPool setter.

    @cygnusv
    cygnusv committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b2eb840 View commit details
    Browse the repository at this point in the history