-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porter now supports CBD threshold decryption (base support and not yet E2EE) #26
Merged
derekpierre
merged 11 commits into
nucypher:development
from
derekpierre:unencrypted-dkg-support
May 23, 2023
Merged
Porter now supports CBD threshold decryption (base support and not yet E2EE) #26
derekpierre
merged 11 commits into
nucypher:development
from
derekpierre:unencrypted-dkg-support
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #26 +/- ##
===============================================
- Coverage 89.28% 87.37% -1.91%
===============================================
Files 17 17
Lines 644 705 +61
===============================================
+ Hits 575 616 +41
- Misses 69 89 +20
|
theref
reviewed
May 16, 2023
porter/interfaces.py
Outdated
@@ -35,7 +35,7 @@ def __init__(self, porter: 'Porter' = None, *args, **kwargs): | |||
# | |||
# Alice Endpoints | |||
# | |||
@attach_schema(schema.AliceGetUrsulas) | |||
@attach_schema(schema.PREGetUrsulas) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love these changes
derekpierre
changed the title
Porter now supports CBD threshold decryption (base support and not yet E2E)
Porter now supports CBD threshold decryption (base support and not yet E2EE)
May 17, 2023
piotr-roslaniec
approved these changes
May 18, 2023
…2e-dkg dev branch for nucypher/nucypher.
… additional testing.
… rebase, and `nucypher` PRs have been merged.
derekpierre
force-pushed
the
unencrypted-dkg-support
branch
from
May 23, 2023 14:36
25e94ea
to
7388ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added threshold decryption support to Porter - the ThresholdDecryptionRequests/Responses are still unencrypted; the E2E part of the protocol will be implemented in the next PR #24 .
Based over #25 .
Stepping stone for nucypher/nucypher#3081.
NOTE:
Before merging, need to update the
nucypher
dependency to no longer point to a branch on my fork, but tonucypher/nucypher
development
branch again. Relies on nucypher/nucypher#3126.I'll take care of the merge once there are sufficient approvals.