Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porter now supports CBD threshold decryption (base support and not yet E2EE) #26

Merged
merged 11 commits into from
May 23, 2023

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented May 11, 2023

Added threshold decryption support to Porter - the ThresholdDecryptionRequests/Responses are still unencrypted; the E2E part of the protocol will be implemented in the next PR #24 .

Based over #25 .

Stepping stone for nucypher/nucypher#3081.

NOTE:
Before merging, need to update the nucypher dependency to no longer point to a branch on my fork, but to nucypher/nucypher development branch again. Relies on nucypher/nucypher#3126.

I'll take care of the merge once there are sufficient approvals.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #26 (25e94ea) into development (f185a61) will decrease coverage by 1.91%.
The diff coverage is 97.08%.

@@               Coverage Diff               @@
##           development      #26      +/-   ##
===============================================
- Coverage        89.28%   87.37%   -1.91%     
===============================================
  Files               17       17              
  Lines              644      705      +61     
===============================================
+ Hits               575      616      +41     
- Misses              69       89      +20     
Impacted Files Coverage Δ
porter/fields/umbralkey.py 93.33% <85.71%> (ø)
porter/fields/base.py 97.56% <90.90%> (-2.44%) ⬇️
porter/fields/ursula.py 100.00% <100.00%> (ø)
porter/interfaces.py 97.43% <100.00%> (+0.37%) ⬆️
porter/main.py 87.12% <100.00%> (+1.28%) ⬆️
porter/schema.py 98.64% <100.00%> (+0.31%) ⬆️
porter/utils.py 81.81% <100.00%> (ø)

... and 2 files with indirect coverage changes

@@ -35,7 +35,7 @@ def __init__(self, porter: 'Porter' = None, *args, **kwargs):
#
# Alice Endpoints
#
@attach_schema(schema.AliceGetUrsulas)
@attach_schema(schema.PREGetUrsulas)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love these changes

porter/interfaces.py Show resolved Hide resolved
@derekpierre derekpierre changed the title Porter now supports CBD threshold decryption (base support and not yet E2E) Porter now supports CBD threshold decryption (base support and not yet E2EE) May 17, 2023
@derekpierre derekpierre merged commit 52035f7 into nucypher:development May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants