Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid converting the return value to JsValue in generate_kfrags() #26

Open
fjarri opened this issue Nov 30, 2020 · 1 comment
Open

Avoid converting the return value to JsValue in generate_kfrags() #26

fjarri opened this issue Nov 30, 2020 · 1 comment
Labels
blocked Blocked by a third-party library WASM Related to WASM bindings

Comments

@fjarri
Copy link
Contributor

fjarri commented Nov 30, 2020

A vector or a box of custom structs cannot currently be returned from a function (see rustwasm/wasm-bindgen#111). So generate_kfrags() has to convert KeyFrags to JsValues, which will make testing harder. Need to fix it when the blocker is fixed.
@fjarri fjarri added WASM Related to WASM bindings blocked Blocked by a third-party library labels Nov 30, 2020
@fjarri fjarri mentioned this issue Sep 18, 2022
Merged
@fjarri
Copy link
Contributor Author

fjarri commented Sep 19, 2022

Now using a custom type VerifiedKeyFragArray declared as TS VerifiedKeyFrag[] and a manual conversion, to generate a correct TS signature. The internals can be updated when wasm-bindgen fixes the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked by a third-party library WASM Related to WASM bindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fjarri