-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bindings simplification #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjarri
added
WASM
Related to WASM bindings
Python
Related to Python bindings
API
Related to public API
labels
Sep 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 58.76% 60.55% +1.79%
==========================================
Files 17 17
Lines 1484 1440 -44
==========================================
Hits 872 872
+ Misses 612 568 -44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fjarri
force-pushed
the
bindings-simplification
branch
from
September 19, 2022 04:45
d42ae5d
to
e133001
Compare
piotr-roslaniec
approved these changes
Sep 19, 2022
fjarri
force-pushed
the
bindings-simplification
branch
from
September 19, 2022 22:29
6912254
to
c4b4591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsBackend
/FromBackend
,.inner()
,.new()
, andpub backend
with derivedAsRef/From/Into
where appropriatejs_sys::Error
instead of justJsValue
in resultswasm-bindgen-derive
to supportOption<&T>
(Simplify verification of KeyFrag in WASM bindings #25),&Vec<T>
arguments (Support taking an array of cfrags indecrypt_reencrypted()
in WASM bindings #23), andVec<T>
return values (Avoid converting the return value toJsValue
ingenerate_kfrags()
#26). Generate correct TypeScript signatures in this case.serde
usage in WASM bindings -nucypher-core
will not need it (thanks to the above workaround)ciphertext
in EncryptionResult #24 - nowencrypt()
returns an actual tuple in the WASM bindings