-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated actions-rs/*
GH Actions
#133
Replace deprecated actions-rs/*
GH Actions
#133
Conversation
10974b5
to
a1feeaf
Compare
67a9581
to
f26eb43
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 58.08% 58.08%
=======================================
Files 17 17
Lines 3123 3123
=======================================
Hits 1814 1814
Misses 1309 1309 ☔ View full report in Codecov by Sentry. |
actions-rs/*
GH Actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👌
@@ -59,7 +59,7 @@ fn hash(data: impl AsRef<[u8]>) -> i64 { | |||
// we just need something fast that minimizes conflicts. | |||
let digest = Sha256::new().chain(data).finalize(); | |||
let (chunk, _): (GenericArray<u8, U8>, _) = digest.split(); | |||
let arr: [u8; 8] = chunk.try_into().unwrap(); | |||
let arr: [u8; 8] = chunk.into(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity: is this change related to these GH Actions in some way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's an accidental change. It's possible that clippy
was updated between the previous CI run and now, and it resulted in a broken linter rule.
Type of PR:
Required reviews:
What this does:
actions-rs/*
GH Actions ferveo#153actions-rs/*
GH Actions nucypher-core#90