Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated actions-rs/* GH Actions #133

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

piotr-roslaniec
Copy link
Contributor

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (47867d2) 58.08% compared to head (f26eb43) 58.08%.

Files Patch % Lines
umbral-pre/src/bindings_python.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   58.08%   58.08%           
=======================================
  Files          17       17           
  Lines        3123     3123           
=======================================
  Hits         1814     1814           
  Misses       1309     1309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec changed the title chore(ci): replace deprecated action-rs gh actions Replace deprecated actions-rs/* GH Actions Jan 22, 2024
@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review January 22, 2024 14:18
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

@@ -59,7 +59,7 @@ fn hash(data: impl AsRef<[u8]>) -> i64 {
// we just need something fast that minimizes conflicts.
let digest = Sha256::new().chain(data).finalize();
let (chunk, _): (GenericArray<u8, U8>, _) = digest.split();
let arr: [u8; 8] = chunk.try_into().unwrap();
let arr: [u8; 8] = chunk.into();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: is this change related to these GH Actions in some way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's an accidental change. It's possible that clippy was updated between the previous CI run and now, and it resulted in a broken linter rule.

@piotr-roslaniec piotr-roslaniec merged commit b3eaa7a into nucypher:master Jan 22, 2024
14 checks passed
@piotr-roslaniec piotr-roslaniec deleted the replace-actions-rs branch January 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants