Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ritual initialization #265

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Disable ritual initialization #265

merged 1 commit into from
Aug 14, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Aug 11, 2023

Type of PR:

  • Feature

Required reviews:

  • 1

What this does:

  • Replaces optionality from ritualId parameter
  • Disables ritual initialization on the client

Issues fixed/closed:

  • Fixes #...

Why it's needed:

  • Ritual initialization is not supported during v7.0.0

Notes for reviewers:

@github-actions
Copy link

Bundled size for the package is listed below:

build/module/src/kits: 19.53 KB
build/module/src/characters: 74.22 KB
build/module/src/policies: 19.53 KB
build/module/src/agents: 39.06 KB
build/module/src/conditions/predefined: 19.53 KB
build/module/src/conditions/base: 54.69 KB
build/module/src/conditions/context: 42.97 KB
build/module/src/conditions: 156.25 KB
build/module/src/sdk/strategy: 31.25 KB
build/module/src/sdk: 42.97 KB
build/module/src: 429.69 KB
build/module/types/ethers-contracts/factories: 82.03 KB
build/module/types/ethers-contracts: 152.34 KB
build/module/types: 156.25 KB
build/module: 640.63 KB
build/main/src/kits: 19.53 KB
build/main/src/characters: 74.22 KB
build/main/src/policies: 19.53 KB
build/main/src/agents: 39.06 KB
build/main/src/conditions/predefined: 19.53 KB
build/main/src/conditions/base: 54.69 KB
build/main/src/conditions/context: 42.97 KB
build/main/src/conditions: 156.25 KB
build/main/src/sdk/strategy: 35.16 KB
build/main/src/sdk: 46.88 KB
build/main/src: 437.50 KB
build/main/types/ethers-contracts/factories: 82.03 KB
build/main/types/ethers-contracts: 152.34 KB
build/main/types: 156.25 KB
build/main: 648.44 KB
build: 1.26 MB

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #265 (7447664) into alpha (e4f824d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            alpha     #265      +/-   ##
==========================================
+ Coverage   80.35%   80.37%   +0.02%     
==========================================
  Files          36       36              
  Lines        1008     1004       -4     
  Branches      116      114       -2     
==========================================
- Hits          810      807       -3     
+ Misses        190      189       -1     
  Partials        8        8              
Files Changed Coverage Δ
src/sdk/strategy/cbd-strategy.ts 93.33% <100.00%> (+1.49%) ⬆️

@piotr-roslaniec piotr-roslaniec merged commit 88c4614 into alpha Aug 14, 2023
12 checks passed
@piotr-roslaniec piotr-roslaniec deleted the disable-ritual-init branch August 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants