Apply PR suggestions for #273 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
changed the title
piotr-roslaniec
force-pushed
the
nucypher-core-0.12.0
branch
from
2c3b18b
to
e46a6a6
Compare
1 task
piotr-roslaniec
force-pushed
the
nucypher-core-0.12.0
branch
from
e46a6a6
to
aad5942
Compare
Codecov Report
@@ Coverage Diff @@
## alpha #286 +/- ##
==========================================
+ Coverage 80.99% 81.74% +0.75%
==========================================
Files 36 36
Lines 1021 1063 +42
Branches 110 119 +9
==========================================
+ Hits 827 869 +42
Misses 186 186
Partials 8 8
... and 7 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
piotr-roslaniec
requested review from
jMyles,
KPrasch,
cygnusv,
theref,
derekpierre and
manumonti
piotr-roslaniec
force-pushed
the
nucypher-core-0.12.0
branch
from
aad5942
to
cb258e4
Compare
derekpierre
reviewed
Sep 5, 2023
piotr-roslaniec
commented
Sep 6, 2023
piotr-roslaniec
force-pushed
the
nucypher-core-0.12.0
branch
from
dfc1aca
to
dcc741b
Compare
derekpierre
reviewed
Sep 6, 2023
piotr-roslaniec
force-pushed
the
nucypher-core-0.12.0
branch
from
4ca142b
to
e6f7d0a
Compare
piotr-roslaniec
force-pushed
the
nucypher-core-0.12.0
branch
from
e6f7d0a
to
b11f1d4
Compare
derekpierre
reviewed
Sep 8, 2023
theref
approved these changes
Sep 8, 2023
manumonti
approved these changes
Sep 8, 2023
src/conditions/context/context.ts
Outdated
|
|
||
| public static fromConditions( | ||
| provider: ethers.providers.Provider, | ||
| conditions: Conditions, |
There was a problem hiding this comment.
Suggested change
| conditions: Conditions, | |
| conditions: WASMConditions, |
Probably not relevant at all, but this argument is for WASMCondition, right?
If this suggestion is accepted, we should remove the line 2 of this file, the import of Conditions
|
LGTM! ✌️ But I left a nitpicky question |
piotr-roslaniec
force-pushed
the
nucypher-core-0.12.0
branch
from
12768d1
to
822ac79
Compare
piotr-roslaniec
force-pushed
the
nucypher-core-0.12.0
branch
from
822ac79
to
363718f
Compare
This was referenced Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
nucypher-core@0.12.0#273nucypher-core#269nucypher-core::Conditionsusage #293