Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioSession이 Deactive되었을때 AudioSession을 다시 업데이트 하는 현상 제거 #1143

Merged
merged 1 commit into from
Mar 14, 2024
Merged

AudioSession이 Deactive되었을때 AudioSession을 다시 업데이트 하는 현상 제거 #1143

merged 1 commit into from
Mar 14, 2024

Conversation

ParkJongSang
Copy link
Contributor

Summary

@ParkJongSang ParkJongSang self-assigned this Mar 12, 2024
@jayce1116
Copy link
Collaborator

#961 에서 사이드이펙트 발생해서 revert시켰었어요. 현재 상황으로 사이드이펙트가 안나는지 정확하게 체크해봐야 할 것 같아요

@ParkJongSang ParkJongSang changed the base branch from master to develop/1.9.4 March 14, 2024 01:26
@jayce1116
Copy link
Collaborator

과거에 PlayNowInfoCenter가 오동작하고 다음 발화가 느려지는 문제가 있어서 revert했습니다. 히스토리 차 남겨둡니다.

@ParkJongSang ParkJongSang merged commit 9f4d279 into nugu-developers:develop/1.9.4 Mar 14, 2024
1 check passed
@ParkJongSang ParkJongSang deleted the fix/update_audio_session branch March 14, 2024 08:10
jayce1116 pushed a commit that referenced this pull request Mar 15, 2024
@ParkJongSang @jayce1116
AudioSession이 Deactive되었을때 AudioSession을 다시 업데이트 하는 현상 제거 (#1143)
6331319 
## Summary
- AudioSession이 Deactive되었을때 AudioSession을 다시 업데이트 하는 현상 제거
- #961 에서 변경된 코드이나 여기서
일부는 코드가 다른곳으로 옮겨짐
- 그러나 deactive시 updateAudioSession()하는 코드를 제거했으나 revert되면서 다시
추가됨(#965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayce1116 jayce1116 jayce1116 approved these changes

@childc childc Awaiting requested review from childc childc is a code owner

Assignees

@ParkJongSang ParkJongSang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ParkJongSang @jayce1116