Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with developer bucket access and poster genertion #3477

Closed
wants to merge 2 commits into from

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Aug 3, 2023

Summary

Fixes bug with Cloudfront cache invalidation when changing a poster image.

Specific Changes in this PR

Version bump required by the PR

See Semantic Versioning 2.0.0 for help discerning which is required.

  • Patch
  • Minor
  • Major

Steps to Test

  • Make sure your dev environment is updated with changes ☝️
  • Confirm video does not error on the transcoding step during ingest
  • Update a poster image (on file set that already has poster image), UI thumbnail should update (you may need to refresh your browser)
  • Any IIIF poster image URL that has been previously requested (exact dimensions, etc) will show the new image rather than the old)

🚀 Deployment Notes

Note - if you check any of these boxes go to the (always open) main <- staging PR and add detailed notes and instructions to help out others who may end up deploying your changes to production

  • Backward compatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Backwards-incompatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Requires data migration
  • Requires database triggers disabled during deployment/migration
  • Requires reindex
  • Terraform changes
    • Adds/requires new or changed Terraform variables
  • Pipeline configuration changes (requires mix meadow.pipeline.setup run)
  • Requires new variable added to miscellany
  • Specific deployment synchronization instructions with other apps/API's
  • Other specific instructions/tasks

Tested/Verified

  • End users/stakeholders

@kdid kdid force-pushed the 3211-poster-image-update-bug branch from d856e8d to ae3696f Compare August 3, 2023 21:02
@kdid kdid marked this pull request as draft August 4, 2023 13:14
@kdid kdid force-pushed the 3211-poster-image-update-bug branch from 617ca80 to 0a3a6cb Compare August 4, 2023 13:16
@kdid kdid closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant