[W5.11r][F11-B1]Sheikh Umar #755
Conversation
…back from Travis.
This reverts commit 733224c.
…evel3 into W5.11r * 'W5.11r' of https://github.com/Sheikh-Umar/addressbook-level3: Added a test case to StorageFileTest.java Revert "I updated the find command of the User Guide." I updated the find command of the User Guide. no message
…se." This reverts commit b96dc5c.
…ommands case-insensitive.
* commit 'ecf7c7ce71dd9c404c0bef9e6e872a202b35c8d9': (26 commits) no message Converts name to lowercase. no message no message Revert "I updated the add command to make the name entered to lowercase." I updated the add command to make the name entered to lowercase. I updated the StorageFileTest.java. no message Added a test case to StorageFileTest.java Revert "I updated the find command of the User Guide." I updated the find command of the User Guide. no message I stated the sources that I referred to for these particular java files. I made changes to the EditCommand and Parser java files based on feedback from Travis. I updated the code based on feedback from Travis. I updated the EditCommand, HelpCommand, Messages, and Parser java files. I updated the user command for the edit command. I corrected a typo error. Updated UniquePersonList based on feedback from Travis. I updated the Sort Command message based on feedback from Travis. ...
|
Hey @Sheikh-Umar! It's ok, you only need to do 1 enhancement for 5.11r to get all the missing credit so far! Don't have to commit anymore, haha. I will review after tomorrow's tutorial. Please make proper commit headers though. Use the imperative tone (You don't have to say "I did ________"), for example the commit header should just be |
|
@karrui May I know if I can still get the missing credit that I missed out even if the Travis CI failed a check? I may have 2 enhancements but I made an enhancement that caused a failed test case and I'm now finding the bug. |
|
Since you only need 1 end to end enhancement, if all tests depending on that enhancement that you choose passes, you will get credit. Looking at your commits, only the sort function is a real end to end enhancement. Focus on that enhancement.
Remember to get credit you will need to add test cases for the enhancement and update the documentation for that enhancement.
Regards, Karrui
…________________________________
From: Sheikh-Umar <notifications@github.com>
Sent: Thursday, March 8, 2018 9:54:24 PM
To: nus-cs2103-AY1718S2/addressbook-level3
Cc: Kar Rui Lau; Mention
Subject: Re: [nus-cs2103-AY1718S2/addressbook-level3] [W5.11r][F11-B1]Sheikh Umar (#755)
@karrui<https://github.com/karrui> May I know if I can still get the missing credit that I missed out even if the Travis CI failed a check?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#755 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVG5EEN5jcFCtSmiwS9TMlMaotIYdYeFks5tcTgQgaJpZM4SbXFi>.
|
| * by updating his/her atttribute with the new value. | ||
| */ | ||
|
|
||
| //Solution below adapted from https://github.com/nus-cs2103-AY1718S2/addressbook-level3/pull/749/files |
There was a problem hiding this comment.
We do not condone wholesale copying of enhancements for LO submissions. Do not do this again. Since you have the sort command, I will be only reviewing the sort command enhancement.
| public void execute_sort_showsAllPerson() throws Exception { | ||
| // prepare expectations | ||
| TestDataHelper helper = new TestDataHelper(); | ||
| Person person1 = helper.generatePersonWithName("John Tan"); |
There was a problem hiding this comment.
Might want to name these variables John, Ali, etc instead of person1 person2 so as to make the generation of expectedList and unorderedList more readable.
| List<Person> expectedList = helper.generatePersonList(person2, person4, person3, person1); | ||
| List<Person> unorderedList = helper.generatePersonList(person1, person2, person3, person4); | ||
|
|
||
| AddressBook expectedAB = helper.generateAddressBook(unorderedList); |
There was a problem hiding this comment.
Why is your expectedAB generated from the unorderedList? Should it not be from expectedList?
You might have meant unorderedAB instead?
Enhancement 1: Added a sort command.
Enhancement 2: Added an edit command.