[W5.11r] [W13-B4] Natania Djohari #774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@natania-d Some comments added. Please close the PR after reading comments.
| @@ -38,6 +38,10 @@ Examples: | |||
| Shows a list of all persons in the address book.<br> | |||
| Format: `list` | |||
|
|
|||
| ## Sorting all persons : `sort` | |||
| Sorts a list of all persons in lexicographical order. <br> | |||
There was a problem hiding this comment.
Since the sort command also displays the resulting list of sorted persons, it would be meaningful to document this behaviour too =).
| @@ -201,6 +201,24 @@ public void execute_list_showsAllPersons() throws Exception { | |||
| expectedList); | |||
| } | |||
|
|
|||
| @Test | |||
| public void execute_sort() throws Exception { | |||
There was a problem hiding this comment.
Great job adding in the corresponding test for the feature! =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sort command