Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lee Shang Jun Xavier] A-CodeQuality #341

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Commits on Aug 6, 2019

  1. Configuration menu
    Copy the full SHA
    65f72a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Add sample checkstyle configuration

    Add toolVersion block in to Gradle code sample to prevent errors.
    j-lum committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    0112efe View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. Configuration menu
    Copy the full SHA
    cfd6da7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request nus-cs2103-AY1920S2#12 from j-lum/gradle+x

    Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)
    j-lum authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    6e6ace1 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. Add configuration for console applications

    Gradle defaults to an empty stdin which results in runtime exceptions
    when attempting to read from `System.in`. Let's add some sensible
    defaults for students who may still need to work with the standard
    input stream.
    j-lum committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    a3ca5a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. Merge pull request nus-cs2103-AY1920S2#13 from j-lum/javaexec

    Add configuration for console applications
    j-lum authored Aug 21, 2019
    Configuration menu
    Copy the full SHA
    7b60e81 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. JavaFX tutorial: Support cross-platform JARs

    The OpenJFX plugin expects applications to be modular and bundled
    with jlink, resulting in fat jars that are not cross-platform. Let's
    manually include the required dependencies so that shadow can package
    them properly.
    j-lum committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    c4678f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. Configuration menu
    Copy the full SHA
    30efbae View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2020

  1. Level-1

    lsjxavier committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    9bef9af View commit details
    Browse the repository at this point in the history
  2. Level-2

    lsjxavier committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    edff645 View commit details
    Browse the repository at this point in the history
  3. Level-3

    lsjxavier committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    d303522 View commit details
    Browse the repository at this point in the history
  4. Level-4

    lsjxavier committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    c0e4482 View commit details
    Browse the repository at this point in the history
  5. A-TextUiTesting

    lsjxavier committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    6eb8c6e View commit details
    Browse the repository at this point in the history
  6. A-TextUiTesting

    lsjxavier committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    8417caa View commit details
    Browse the repository at this point in the history
  7. Level-5

    lsjxavier committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    d045270 View commit details
    Browse the repository at this point in the history
  8. Level-6

    lsjxavier committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    2070a30 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. Level-6

    lsjxavier committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    ba8cd09 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2020

  1. Configuration menu
    Copy the full SHA
    ee41b14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b68b03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    defc074 View commit details
    Browse the repository at this point in the history
  4. (A-OOP) Reorganized code

    lsjxavier committed Jan 26, 2020
    Configuration menu
    Copy the full SHA
    bd31f52 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    50738c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. Minor code cleanup

    lsjxavier committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    bb2eb23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    64a857b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ea2f59c View commit details
    Browse the repository at this point in the history
  4. (A-CodingStandard)

    lsjxavier committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    9a6c7d6 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'branch-A-JavaDoc'

    * branch-A-JavaDoc:
      (A-JavaDoc) Added JavaDoc comments to classes relating to Task and TaskList.
    lsjxavier committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    3463e05 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'branch-A-CodingStandard'

    * branch-A-CodingStandard:
      (A-CodingStandard)
    lsjxavier committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    bec5ee1 View commit details
    Browse the repository at this point in the history
  7. no message

    lsjxavier committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    ef0552a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    72cf6db View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Configuration menu
    Copy the full SHA
    7f308c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. Merge branch 'gradle' of https://github.com/lsjxavier/duke into A-Gradle

    * 'gradle' of https://github.com/lsjxavier/duke:
      JavaFX tutorial: Support cross-platform JARs
      Add configuration for console applications
      Change file mode on `gradle` to be executable
      Add sample checkstyle configuration
      Add support for Gradle workflow
    lsjxavier committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    c1beca6 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Added support for Gradle

    lsjxavier committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    0f700f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b9b1c4 View commit details
    Browse the repository at this point in the history
  3. (Level-10) Added images

    lsjxavier committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    86d4e5c View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Configuration menu
    Copy the full SHA
    c536fd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97cc952 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Configuration menu
    Copy the full SHA
    0069c1e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Updated README.md

    lsjxavier committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    9e42c73 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Updated Code Quality

    lsjxavier committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    1b318cb View commit details
    Browse the repository at this point in the history
  2. Removed assertions

    lsjxavier committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    58688c6 View commit details
    Browse the repository at this point in the history
  3. Amended name of method.

    lsjxavier committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    5cd4657 View commit details
    Browse the repository at this point in the history