Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2113T-F11-1] The Schwarzenegger #113

Open
wants to merge 977 commits into
base: master
Choose a base branch
from
Open

[CS2113T-F11-1] The Schwarzenegger #113

wants to merge 977 commits into from

Conversation

tienkhoa16
Copy link

PR subject: The Schwarzenegger

The Schwarzenegger helps people keep track of their daily workout routines and daily nutritional intake. It is optimized for CLI users so that recording can be done faster by typing in commands.

thatseant
thatseant reviewed Oct 29, 2020
View reviewed changes
Copy link

@thatseant thatseant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi good job on the DG! Left some comments...

docs/pictures/zesong/DeleteWS.puml Show resolved Hide resolved
docs/pictures/zesong/model.puml Show resolved Hide resolved
docs/pictures/zesong/NewWS.puml Show resolved Hide resolved
src/main/java/commands/CommandLib.java Outdated Show resolved Hide resolved
@1-Karthigeyan-1
Copy link

image
Under 4.2.2 viewing a profile , is it possible to explain the difference between the 2 result outcomes in the optional pathway?

@1-Karthigeyan-1
Copy link

1-Karthigeyan-1 commented Oct 29, 2020 •
edited
Loading

image

I believe there might be a typo for PastRecordList.

@1-Karthigeyan-1
Copy link

image
Under 4.4.1.2. Deleting an Exercise, the implementation and the diagram does not mention the delete functionality.

Zhangyilin0203
Zhangyilin0203 reviewed Oct 29, 2020
View reviewed changes
Copy link

@Zhangyilin0203 Zhangyilin0203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good job!

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
yuqiaoluolong
yuqiaoluolong reviewed Oct 29, 2020
View reviewed changes
Copy link

@yuqiaoluolong yuqiaoluolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are sufficient diagrams and most are well drawn.

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
qkbrandon
qkbrandon reviewed Oct 29, 2020
View reviewed changes
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
qkbrandon
qkbrandon reviewed Oct 29, 2020
View reviewed changes
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
qkbrandon
qkbrandon reviewed Oct 29, 2020
View reviewed changes
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
qkbrandon
qkbrandon reviewed Oct 29, 2020
View reviewed changes
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
qkbrandon
qkbrandon reviewed Oct 29, 2020
View reviewed changes
Copy link

@qkbrandon qkbrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed, very nice.

tienkhoa16 and others added 19 commits November 8, 2020 18:38
@tienkhoa16
Move parser test code in parser package
c9fe146
@tienkhoa16
Refactor magic number and string in profile parser
7c12364
@tienkhoa16
update common parser test
6ac3374
@yujinyang1998
Add javaDoc for all public Workout Session methods
2aad4b4
@yujinyang1998
Merge pull request #219 from CFZeon/master
1283edd 
update user stories in DG
@yujinyang1998
Merge branch 'master' of https://github.com/AY2021S1-CS2113T-F11-1/tp
f0d57c3
@yujinyang1998
Refactor test for WorkoutSessionParser
bf778fb
@CFZeon
Merge pull request #220 from yujinyang1998/master
3dfd5cc 
Add javaDoc for all public Workout Session methods
@yujinyang1998
Update User guide
022a57e
@tienkhoa16
Move InsufficientArgumentException out to common exceptions package
85b047c
@tienkhoa16
Add test for profile help
eda14de
@CFZeon
Merge pull request #221 from yujinyang1998/master
5c78ca5 
Update User guide
@yujinyang1998
Update search format for diet session in help message and user guide
17c4b22
@yujinyang1998
Merge branch 'master' of https://github.com/AY2021S1-CS2113T-F11-1/tp
d8793d2
@tienkhoa16
Add Profile Session test
6e3db36
@wgzesg
fixed workoutmanager dates bug
96be087
@tienkhoa16
Update profile session test
0e4ac8a
@tienkhoa16
Merge pull request #222 from yujinyang1998/master
c750d14 
 Update search format for diet session in help message and user guide
@tienkhoa16
Merge branch 'master' of https://github.com/AY2021S1-CS2113T-F11-1/tp …
1788d28 
…into branch-oop
yujinyang1998 and others added 30 commits November 9, 2020 22:57
@yujinyang1998
Update ppp
80ad1ef
@zsk612
Merge pull request #269 from zsk612/branch-refactor
e291b89 
update ug
@yujinyang1998
Merge branch 'master' of https://github.com/AY2021S1-CS2113T-F11-1/tp
3c714b8
@yujinyang1998
Merge pull request #270 from yujinyang1998/master
6aa9413 
Update ppp
@zsk612
update ug
92032dc
@zsk612
Merge pull request #271 from zsk612/branch-refactor
7830171 
update ug
@zsk612
udpate ppp
5fdf8f7
@zsk612
Merge pull request #272 from zsk612/branch-refactor
162f516 
udpate ppp
@zsk612
update dg
4c38207
@yujinyang1998
Update UG
cde50ba
@zsk612
Merge pull request #273 from zsk612/branch-refactor
13a418f 
update dg
@yujinyang1998
Merge branch 'master' of https://github.com/AY2021S1-CS2113T-F11-1/tp
acbc479
@yujinyang1998
Merge pull request #274 from yujinyang1998/master
7eeddbd 
Update ug
@CFZeon
remove line from uml diagram
37349a0
@CFZeon
Merge pull request #275 from CFZeon/master
24e38e5 
remove line from uml diagram
@zsk612
update ug
b311878
@zsk612
Merge pull request #276 from zsk612/branch-refactor
eedf667 
update ug
@CFZeon
update uml diagram
e552099
@CFZeon
Merge branch 'master' of https://github.com/AY2021S1-CS2113T-F11-1/tp
2b68ff1
@CFZeon
Merge pull request #277 from CFZeon/master
073cf26 
update uml diagram
@yujinyang1998
Update ug
d7e3710
@yujinyang1998
Merge branch 'master' of https://github.com/AY2021S1-CS2113T-F11-1/tp
1a067bd
@yujinyang1998
Update UG
70703d3
@yujinyang1998
Merge pull request #278 from yujinyang1998/master
6b4ccf7 
Update ug
@yujinyang1998
Update ug
88d7ef9
@yujinyang1998
Merge pull request #279 from yujinyang1998/master
5985a90 
Update ug
@yujinyang1998
Update ug
740ef04
@yujinyang1998
Merge branch 'master' of https://github.com/AY2021S1-CS2113T-F11-1/tp
fa8b081
@yujinyang1998
Merge pull request #280 from yujinyang1998/master
8ffe077 
Update ug
@wgzesg @gitbook-bot
GitBook: [master] 17 pages and 90 assets modified
94efcbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatseant thatseant thatseant left review comments

@1-Karthigeyan-1 1-Karthigeyan-1 1-Karthigeyan-1 left review comments

@yuqiaoluolong yuqiaoluolong yuqiaoluolong left review comments

@qkbrandon qkbrandon qkbrandon left review comments

@Zhangyilin0203 Zhangyilin0203 Zhangyilin0203 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tienkhoa16 @1-Karthigeyan-1 @thatseant @yuqiaoluolong @qkbrandon @Zhangyilin0203 @yujinyang1998 @CFZeon @wgzesg @zsk612