Skip to content

Commit

Permalink
Addressing the comments
Browse files Browse the repository at this point in the history
  • Loading branch information
akshmish committed Jul 17, 2023
1 parent b3e53b8 commit 8c311dd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions common/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ const (

PROFILE_STATUS_READY = "READY"

TIMEZONE_UTC = "UTC"

PROFILE_TYPE_COMPUTE = "Compute"
PROFILE_TYPE_DATABASE_PARAMETER = "Database_Parameter"
PROFILE_TYPE_DATABASE_PARAMETER_INSTANCE = "Database_Parameter_Instance"
Expand All @@ -72,6 +70,8 @@ const (

SLA_NAME_NONE = "NONE"

TIMEZONE_UTC = "UTC"

TOPOLOGY_ALL = "ALL"
TOPOLOGY_CLUSTER = "cluster"
TOPOLOGY_DATABASE = "database"
Expand Down
4 changes: 2 additions & 2 deletions test/ndb_api_helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ import (

func GetProfileResolvers(d v1alpha1.Database) ndb_api.ProfileResolvers {

// Webhook defaults tje Profiles to empty struct, but while running the UTs,
// defaulter code will not come into picture - so manually initialzing in tests
// Webhook defaults the Profiles to an empty struct, but while running the UTs, the
// FDfaulter logic will not be run - so manually initialzing Profiles struct here
if d.Spec.Instance.Profiles == nil {
d.Spec.Instance.Profiles = &(v1alpha1.Profiles{})
}
Expand Down

0 comments on commit 8c311dd

Please sign in to comment.