New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for Web-hooks and converting the top-level Instance Spec fields to pointers #129

Merged

akshmish merged 23 commits into main from pointers

Jul 20, 2023

Contributor

akshmish commented Jul 13, 2023 •

edited

Loading

What this PR does / why we need it:

Converts the structs input fields into Pointers.
Add Functional Tests for the Web-hooks

How Has This Been Tested?:

Test Spec:
https://docs.google.com/document/d/1bxNGsA3JU9bktCfjEbYoq51kQLqi9QTGiejK1D0THCc/edit

akshmish added 2 commits

July 13, 2023 14:44


          Converting TMInfo field to pointer


          Converting Profiles spec into pointer

d0e8562

akshmish changed the title ~~Converting TMInfo field to pointer~~ Converting structs from the DB spec to pointers

akshmish added 4 commits

July 14, 2023 09:26


          Converting more primitive spec fields to pointers

9daf1ba


          Converting db size into pointer and improving the error message for v…

ca00e83

…alidation logic


          Converting databaseNames field into a pointer

959ac74


          Improving error messages

1e2ef15

akshmish marked this pull request as ready for review

July 14, 2023 17:41

akshmish requested review from manavrajvanshi, yash-ntnx and shenoypritika and removed request for yash-ntnx

July 14, 2023 17:41

akshmish changed the title ~~Converting structs from the DB spec to pointers~~ Converting the top-level Instance Spec structs to pointers


          Handle empty database names case

5097eb5

manavrajvanshi requested changes

View reviewed changes

api/v1alpha1/database_types.go Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

common/constants.go Outdated Show resolved Hide resolved

config/manager/kustomization.yaml Outdated Show resolved Hide resolved

test/ndb_api_helpers_test.go Outdated Show resolved Hide resolved

akshmish added 3 commits

July 17, 2023 11:01


          Fixing typos

b3e53b8


          Addressing the comments

8c311dd


          Refactoring method signature for validate and create

a95382b

akshmish requested a review from manavrajvanshi

July 17, 2023 22:12

shenoypritika suggested changes

View reviewed changes

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Show resolved Hide resolved

api/v1alpha1/database_webhook.go Show resolved Hide resolved

yash-ntnx reviewed

View reviewed changes

Makefile Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

api/v1alpha1/zz_generated.deepcopy.go Outdated Show resolved Hide resolved

manavrajvanshi requested changes

View reviewed changes

api/v1alpha1/database_webhook.go Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

manavrajvanshi and others added 2 commits

July 18, 2023 07:31


          Merge branch 'main' into pointers

241435e


          Reverting the temporary change in docker repo

34acc95

akshmish requested review from manavrajvanshi, shenoypritika and yash-ntnx

July 18, 2023 15:51

yash-ntnx approved these changes

View reviewed changes

akshmish changed the title ~~Converting the top-level Instance Spec structs to pointers~~ Converting the top-level Instance Spec fields to pointers

akshmish added 6 commits

July 18, 2023 12:29


          Fix the empty database name use case

f6a8511


          Add a gingko test

6072dd4


          Adding functional tests for the Webhooks

c5b82f0


          Adding FT for TM and profiles

1904a1a


          Fix tests

5e2debc


          Adding TM missing test case

d9b0cb5

akshmish requested a review from yash-ntnx

July 19, 2023 18:23

shenoypritika suggested changes

View reviewed changes

api/v1alpha1/webhook_suite_test.go Outdated Show resolved Hide resolved

api/v1alpha1/webhook_suite_test.go Outdated Show resolved Hide resolved

api/v1alpha1/webhook_suite_test.go Outdated Show resolved Hide resolved


          Update description

1a0608e

manavrajvanshi approved these changes

View reviewed changes

Contributor

manavrajvanshi left a comment

Looks good with follow ups on:

Pointer for slice type (redundant, can be removed)
Few logs
Reverting your private docker registry

api/v1alpha1/database_types.go Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

api/v1alpha1/database_webhook.go Show resolved Hide resolved

api/v1alpha1/database_webhook.go Outdated Show resolved Hide resolved

akshmish added 2 commits

July 19, 2023 14:41


          Reverting databaseNames pointers change

f9ac824


          Cleaning up test env before and after every test

98189a4

akshmish requested a review from shenoypritika

July 20, 2023 05:25

akshmish added 2 commits

July 19, 2023 22:30


          Revert artifactory url change

ed9de0b


          Improving comments in the code

213440c

akshmish changed the title ~~Converting the top-level Instance Spec fields to pointers~~ Test for Web-hooks and converting the top-level Instance Spec fields to pointers

shenoypritika approved these changes

View reviewed changes

akshmish merged commit 8c4f381 into main

6 checks passed

manavrajvanshi deleted the pointers branch

August 16, 2023 21:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet