docs(tutorial): declare Window members inline, not via extends - #879
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe confetti tutorial updates its global Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This localized tutorial update changes the recommended 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Follow-up to #878.
The confetti tutorial still taught
declare global { interface Window extends JSConfettiApi {} }— the exact shape #878 removes from the registry. Anextendsclause on the globalWindowturns any member collision with another package into an unsuppressable TS2430 at every consumerWindowaugmentation (#852). Declaring the member inline is type-identical and removes that failure mode.Discovered during adversarial review of #878; one-line snippet change, verified by
pnpm lint.