Adds service worker to the skeleton #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisdlopez
force-pushed
the
feature/add-service-worker
branch
from
9181dba
to
3b29317
Compare
| config: true, | ||
| }, | ||
|
|
||
| manifest: { |
There was a problem hiding this comment.
Que penses tu de sortir le manifest dans son propre file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue or Internal Use Azure Devops Work Item ID:
https://dev.azure.com/nventive/Practice%20committees/_workitems/edit/306648/
Proposed Changes
What is the current behavior?
The skeleton does not include the setup for a service worker or any other features related to PWAs
What is the new behavior?
Using the vite PWA plugin, the project is now setup to support service workers
https://vite-pwa-org.netlify.app/guide/
There are 2 service worker strategies: generateSW vs injectManifest.
This setup uses the default generateSW strategy.
Also includes setup for @vite-pwa/assets-generator, to generate icons for the PWA app
Checklist
Please check that your PR fulfills the following requirements:
Other information