fix!(lsp): use generic_sorter for dynamic_workspace_symbols
#3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `highlighter_only` sorter should be reserved for pickers that have finders that already return results in an some good order (ie. like `live_grep`). But this isn't something that language server reliably do and some return results in frankly useless orders. So swapping out the sorter for `conf.generic_sorter`.
jamestrew
force-pushed
the
lsp-dynamic-ws-sorter
branch
from
f50c141
to
5623dc7
Compare
skip-checks: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
highlighter_onlysorter should be reserved for pickers that have finders that already return results in an some good order (ie. likelive_grep). But this isn't something that language server reliably do and some return results in frankly useless orders.So swapping out the sorter for
conf.generic_sorter.This is somewhat of a breaking change.
closes #2104