Skip to content

Commit

Permalink
Disable status bar theming in SelectableListToolbar
Browse files Browse the repository at this point in the history
Nokia devices crash when trying to set to set the status bar color in
bookmarks, history, and downloads. Disable status bar theming for now.

BUG=880694

Change-Id: I48ae7ec0d7aa5059d70eb5a99b23e84d8263dcd0
Reviewed-on: https://chromium-review.googlesource.com/1207310
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588944}(cherry picked from commit 050fc9e)
Reviewed-on: https://chromium-review.googlesource.com/1208351
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#62}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
  • Loading branch information
Theresa committed Sep 5, 2018
1 parent 1f00406 commit 84d4d12
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import android.content.res.ColorStateList;
import android.graphics.Color;
import android.graphics.drawable.Drawable;
import android.os.Build;
import android.support.annotation.CallSuper;
import android.support.annotation.StringRes;
import android.support.v4.view.GravityCompat;
Expand Down Expand Up @@ -183,9 +182,10 @@ public void initialize(SelectionDelegate<E> delegate, int titleResId,
mDrawerLayout = drawerLayout;
mNormalGroupResId = normalGroupResId;
mSelectedGroupResId = selectedGroupResId;
mUpdateStatusBarColor = updateStatusBarColor
&& Build.VERSION.SDK_INT >= Build.VERSION_CODES.M
&& !UiUtils.isSystemUiThemingDisabled();
// TODO(twellington): Setting the status bar color crashes on Nokia devices. Re-enable
// after a Nokia test device is procured and the crash can be debugged.
// See https://crbug.com/880694.
mUpdateStatusBarColor = false;

mSelectionDelegate = delegate;
mSelectionDelegate.addObserver(this);
Expand Down

0 comments on commit 84d4d12

Please sign in to comment.