Skip to content

Commit

Permalink
ChromeOS: Learn More link on EULA screen should not trigger adjacent …
Browse files Browse the repository at this point in the history
…checkbox.

When user hits Enter on focused "Learn More" link of the EULA screen, adjacent
checkbox was involuntary triggered. This CL fixed it.

TBR=alemate@chromium.org

(cherry picked from commit ddacd55)

Bug: 771095
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I500ab0c41934c124a6ee1fa03a1ea7f62faf5485
Reviewed-on: https://chromium-review.googlesource.com/721892
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509454}
Reviewed-on: https://chromium-review.googlesource.com/727661
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#62}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
  • Loading branch information
Alexander Alekseev committed Oct 19, 2017
1 parent c0643eb commit a969e46
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions chrome/browser/resources/chromeos/login/oobe_eula.html
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ <h1 class="title" i18n-content="oobeEulaSectionTitle"></h1>
<div id="logging" class="layout horizontal">
<paper-checkbox id="usageStats" checked="{{usageStatsChecked}}"
on-change="onUsageChanged_">
<div id="usageStatsLabelContainer">
<span i18n-content="checkboxLogging"></span>
<a id="" href="#" i18n-content="learnMore"
on-tap="onUsageStatsHelpLinkClicked_">
</a>
</div>
</paper-checkbox>
<div id="usageStatsLabelContainer">
<span i18n-content="checkboxLogging"></span>
<a id="" href="#" i18n-content="learnMore"
on-tap="onUsageStatsHelpLinkClicked_">
</a>
</div>
</div>
</div>
<div class="bottom-buttons flex layout horizontal">
Expand Down

0 comments on commit a969e46

Please sign in to comment.