Use bullet points instead of asterisk in the save password bubble.

TBR=vasilii@chromium.org

(cherry picked from commit 1009ba6)

Bug: 774516
Change-Id: I17344d16d835a9db9daf1c87824ea9e40ec38baa
Reviewed-on: https://chromium-review.googlesource.com/721544
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509366}
Reviewed-on: https://chromium-review.googlesource.com/727932
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#64}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}

chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

@@ -18,6 +18,7 @@
 #import "ui/base/cocoa/touch_bar_util.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/render_text.h"
 
 namespace {
 
@@ -26,6 +27,8 @@
 NSString* const kNeverTouchBarId = @"NEVER";
 NSString* const kSaveTouchBarId = @"SAVE";
 
+constexpr base::char16 kBulletChar = gfx::RenderText::kPasswordReplacementChar;
+
 void InitEditableLabel(NSTextField* textField, const base::string16& text) {
   [textField setStringValue:base::SysUTF16ToNSString(text)];
   [textField setEditable:YES];
@@ -51,17 +54,17 @@ void FillPasswordCombobox(const autofill::PasswordForm& form,
   for (const base::string16& possible_password : form.all_possible_passwords) {
     [combobox
         addItemWithObjectValue:base::SysUTF16ToNSString(
-                                   visible
-                                       ? possible_password
-                                       : base::string16(
-                                             possible_password.length(), '*'))];
+                                   visible ? possible_password
+                                           : base::string16(
+                                                 possible_password.length(),
+                                                 kBulletChar))];
   }
   [combobox setEditable:visible];
   [combobox
       setStringValue:base::SysUTF16ToNSString(
                          visible ? form.password_value
                                  : base::string16(form.password_value.length(),
-                                                  '*'))];
+                                                  kBulletChar))];
   size_t index = std::distance(
       form.all_possible_passwords.begin(),
       std::find(form.all_possible_passwords.begin(),
@@ -149,7 +152,7 @@ - (void)onEyeClicked:(id)sender {
       offsetY = NSMidY([passwordText_ frame]) - NSMidY(oldFrame);
     } else {
       InitLabel(passwordField_.get(),
-                base::string16(form.password_value.length(), '*'));
+                base::string16(form.password_value.length(), kBulletChar));
       offsetY = NSMaxY([passwordText_ frame]) - NSMaxY(oldFrame);
     }
     [passwordField_ setFrame:NSOffsetRect(oldFrame, 0, offsetY)];
@@ -221,8 +224,8 @@ - (NSView*)createPasswordView {
         passwordField_.reset([PasswordCombobox(form) retain]);
         [passwordField_ setDelegate:self];
       } else {
-        passwordField_.reset(
-            [Label(base::string16(form.password_value.length(), '*')) retain]);
+        passwordField_.reset([Label(
+            base::string16(form.password_value.length(), kBulletChar)) retain]);
         // Overwrite the height of the password field because it's higher in the
         // editable mode.
         [passwordField_

chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

@@ -27,6 +27,8 @@
 #include "testing/gtest_mac.h"
 #import "ui/base/cocoa/touch_bar_forward_declarations.h"
 #import "ui/events/test/cocoa_test_event_utils.h"
+#include "ui/gfx/render_text.h"
+
 // Gmock matcher
 using testing::_;
 
@@ -133,7 +135,9 @@ void TearDown() override {
       base::mac::ObjCCastStrict<NSComboBox>(controller().passwordField);
   EXPECT_FALSE(passwordSelection.editable);
   [passwordSelection selectItemAtIndex:1];
-  EXPECT_NSEQ(@"***", [passwordSelection stringValue]);
+  base::string16 expected(3, gfx::RenderText::kPasswordReplacementChar);
+  EXPECT_NSEQ(base::SysUTF16ToNSString(expected),
+              [passwordSelection stringValue]);
 
   EXPECT_CALL(*ui_controller(), SavePassword(base::ASCIIToUTF16("username"),
                                              base::ASCIIToUTF16("111")));

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

@@ -65,6 +65,8 @@ int ManagePasswordsBubbleView::auto_signin_toast_timeout_ = 3;
 
 namespace {
 
+constexpr base::char16 kBulletChar = gfx::RenderText::kPasswordReplacementChar;
+
 enum ColumnSetType {
   // | | (FILL, FILL) | |
   // Used for the bubble's header, the credentials list, and for simple
@@ -231,7 +233,7 @@ std::unique_ptr<views::ToggleImageButton> CreatePasswordViewButton(
 }
 
 // Creates a dropdown from the other possible passwords.
-// The items are made of '*'s if not visible.
+// The items are made of kBulletChar if not visible.
 std::unique_ptr<views::Combobox> CreatePasswordDropdownView(
     const autofill::PasswordForm& form,
     bool visible) {
@@ -242,7 +244,8 @@ std::unique_ptr<views::Combobox> CreatePasswordDropdownView(
   } else {
     for (const base::string16& possible_password :
          form.all_possible_passwords) {
-      passwords.push_back(base::string16(possible_password.length(), '*'));
+      passwords.push_back(
+          base::string16(possible_password.length(), kBulletChar));
     }
   }
   std::unique_ptr<views::Combobox> combobox = std::make_unique<views::Combobox>(