Skip to content

Commit

Permalink
VR: Stop creating keyboard for DLAs
Browse files Browse the repository at this point in the history
We don't use the keyboard with we're launching Chrome VR for a DLA. Creating it
unnecessarily means a startup slow-down of about 500ms - 1s.

Bug: 804532
Change-Id: Idc351a7233a07047318845999c4ab5cc13c90dc6
Reviewed-on: https://chromium-review.googlesource.com/879092
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531101}(cherry picked from commit 371fc8f)
Reviewed-on: https://chromium-review.googlesource.com/884101
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#61}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
  • Loading branch information
Yash Malik authored and Yash Malik committed Jan 24, 2018
1 parent 94357d6 commit d58c047
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion chrome/browser/android/vr_shell/vr_gl_thread.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ base::WeakPtr<VrShellGl> VrGLThread::GetVrShellGl() {

void VrGLThread::Init() {
bool keyboard_enabled =
base::FeatureList::IsEnabled(features::kVrBrowserKeyboard);
base::FeatureList::IsEnabled(features::kVrBrowserKeyboard) &&
!ui_initial_state_.web_vr_autopresentation_expected;
if (keyboard_enabled) {
keyboard_delegate_ = GvrKeyboardDelegate::Create();
text_input_delegate_ = std::make_unique<vr::TextInputDelegate>();
Expand Down

0 comments on commit d58c047

Please sign in to comment.