forked from qgis/QGIS
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function dfToQGIS #29
Open
JanCaha
wants to merge
44
commits into
nyalldawson:r_console
Choose a base branch
from
JanCaha:r_df_to_QGIS
base: r_console
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Thread safe layer access - QGIS$mapLayerByName('...') - QGIS$featureCount( a layer ) - QGIS$toDataFrame( a layer ) eg summary(QGIS$toDataFrame(QGIS$activeLayer)) summary(QGIS$toDataFrame(QGIS$mapLayerByName('my layer')))
Shaves a few percentage points off the execution time when iterating over OGR layers
This involves quite a dance -- we can't have optional arguments for cpp functions exposed via InternalFunction, so now we have to create pure R wrappers for the exposed functions instead and set the default values for optional arguments in those. The nice thing is that this gives us the opportunity to add R "sugar" to our functions so that they behave more like standard R modules (eg we could add documentation for them)
…ad-safe methods Now available as: - QGIS$toNumericVector(layer, field, selectedOnly) - QGIS$toSf(layer)
So that other non-python-console code editors can utilise this too
nyalldawson
force-pushed
the
r_console
branch
from
October 14, 2022 05:47
60002cb
to
1f9de59
Compare
nyalldawson
force-pushed
the
r_console
branch
from
October 24, 2022 06:59
0636d84
to
24b777c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nicely loads either
data.frame
as layer without geometry orsf
dataframe as classic layer. Works just ok and is reasonably fast.