Add a form to allow panorama uploads to Pano #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+61
to
+65
| src={URL.createObjectURL( | ||
| formSubmission.dropzoneImages.find( | ||
| (file: File) => file.name === k, | ||
| ), | ||
| )} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 29 days ago
To fix the problem, we need to ensure that any data used in the DOM is properly sanitized or validated. Specifically, we should:
- Validate the file objects in
formSubmission.dropzoneImagesbefore using them withURL.createObjectURL. - Ensure that URLs in the
possibleDuplicatesarray are sanitized before being used in the DOM.
We can use a library like DOMPurify to sanitize URLs and ensure that they do not contain any malicious content.
Suggested changeset
2
components/PanoramaDuplicateDialog/PanoramaDuplicateDialog.tsx
| @@ -1,2 +1,3 @@ | ||
| import * as React from "react"; | ||
| import DOMPurify from "dompurify"; | ||
| import Button from "@mui/material/Button"; | ||
| @@ -61,5 +62,5 @@ | ||
| src={URL.createObjectURL( | ||
| formSubmission.dropzoneImages.find( | ||
| DOMPurify.sanitize(formSubmission.dropzoneImages.find( | ||
| (file: File) => file.name === k, | ||
| ), | ||
| )), | ||
| )} | ||
| @@ -96,4 +97,4 @@ | ||
| /> | ||
| <a href={new URL(v).origin + new URL(v).pathname}> | ||
| {new URL(v).origin + new URL(v).pathname} | ||
| <a href={DOMPurify.sanitize(new URL(v).origin + new URL(v).pathname)}> | ||
| {DOMPurify.sanitize(new URL(v).origin + new URL(v).pathname)} | ||
| </a> |
package.json
Outside changed files
| @@ -35,3 +35,4 @@ | ||
| "typescript": "5.3.3", | ||
| "zod": "^3.22.4" | ||
| "zod": "^3.22.4", | ||
| "dompurify": "^3.1.7" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| dompurify (npm) | 3.1.7 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a form to allow panorama uploads to pano: https://github.com/willNilges/pano