-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[curves] introduce wrappers for Fp and Fq #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!
As a sanity check, it would be good to make a Mina PR and make sure that CI is happy there
playing with it here: MinaProtocol/mina#11906 it seems to compile the stubs. Not sure if mina compiles yet, and haven't touched the wasm part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. Can you rework this so that it's only moving the OCaml types into this repo, and leave the rest on the Mina side?
Stale pull request message |
probably we should try this approach first: arkworks-rs/algebra#506 EDIT: actually nevermind, this won't help us with the ocaml traits |
ping @mrmr1993 |
urg actually I don't think this will solve all of our problems for serde at least... Because things like |
This introduces wrapper types for
ark_ff::BigInteger256
as well as for our ownFp
andFq
. These are supposed to add no real overhead as most functions are inlined:(compare this with #750)
The benefit is that we can implement ocaml traits on these.
I also implemented serde serialize/deserialize on them, but I didn't manage to remove the serde_as/serde_with stuff elsewhere. I think it's doable though.