Class inheritance (sign offs rebase) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ verify early that pyyaml isn't missing. this causes 20 fails. + trim whitespace Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
…s recursively). Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
+ add re-emission of interfaces + add emission of inheritance lists + change base holding from set to vector (to preserve order) + fixup base lookup scope (it was target class's scope, must be enclosing) + add a typeof case to exploit inheritance lookup Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
…ed members, and also fully qualified idExpression that were bypassing lookup. Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
wip: advanced / verification of seenats not ready Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
… nameless. Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
…declared prior to a nested type, ended up extracted ABOVE the definition of their own parent type. Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
…ce correctly spawns a o3de#17 error. Signed-off-by: Vivien Oddou <vivien.oddou@siliconstudio.co.jp>
Closed
santorac
approved these changes
Sep 7, 2022
antonmic
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch with replayed and amended commits for forgotten sign offs.
Refer to the original PR for complete report: #58