Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lint: Enum #[must_use] added #278

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

SmolSir
Copy link
Collaborator

@SmolSir SmolSir commented Jan 10, 2023

This is a part of solving #159, as well as splitting #268 into more manageable, smaller PRs.

Implements the check against adding #[must_use] attribute to a public Enum.

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just a few tiny suggested tweaks.

Did you mean to leave this as a draft?

src/lints/enum_must_use_added.ron Outdated Show resolved Hide resolved
test_crates/enum_must_use_added/new/src/lib.rs Outdated Show resolved Hide resolved
test_crates/enum_must_use_added/new/src/lib.rs Outdated Show resolved Hide resolved
SmolSir and others added 3 commits January 10, 2023 21:51
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
@SmolSir SmolSir linked an issue Jan 10, 2023 that may be closed by this pull request
@SmolSir SmolSir marked this pull request as ready for review January 10, 2023 21:24
@obi1kenobi obi1kenobi merged commit 06026c5 into obi1kenobi:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding #[must_use] on an item
2 participants