-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lint struct_with_no_pub_fields_changed
#962
feat: add lint struct_with_no_pub_fields_changed
#962
Conversation
struct_with_no_pub_fields_changed
struct_with_no_pub_fields_changed
…ia `PubStructWithNonPubDocFieldChangedToUnion`
Co-authored-by: Max Carr <m@mcarr.one>
(idk if you get notifications for this, assuming you don't) @obi1kenobi I have reviewed this as thoroughly as possible. Except for the comments above I have not found anything. => I think this is ready for review |
struct_with_no_pub_fields_changed
struct_with_no_pub_fields_changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Especially good job with the query logic, it was trickier than I thought it would be.
There are a handful of remaining items that require another pass before we can merge. Most of them are the kinds of things that would be good to practice catching in your self-reviews: the top difference between a junior engineer and a senior engineer is whether one independently finds the issues in one's own code, or whether someone else has to point them out. So let's work on it together!
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo a small bug in the witness hint. If you can regenerate the witness file with the fix, this should be good to merge!
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
struct_with_no_pub_fields_changed
struct_with_no_pub_fields_changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, nicely done 🚀
This draft is mostly to prevent others thinking that nobody is working on this issue.The query is mostly from
struct_with_pub_fields_changed
There is still some tinkering I need to do with
struct_with_no_pub_fields_changed
#962 (comment)insta
#951, I am going to do that tomorrow though.PubStructWithNonPubDocFieldChangedToUnion
or mark it asTODO
=> feat: add lintstruct_with_no_pub_fields_changed
#962 (comment)Resolves one checkbox of #954