Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to master for v0.7.4 #43

Merged
merged 15 commits into from
Nov 27, 2023
Merged

Merge to master for v0.7.4 #43

merged 15 commits into from
Nov 27, 2023

Commits on Nov 12, 2023

  1. Configuration menu
    Copy the full SHA
    1a22e37 View commit details
    Browse the repository at this point in the history
  2. Fix playlist doc typing

    Playlists were treated as platforms due to typos. Likely broke AM
    taglists, but had no sideffects for LB platforms as modifiedPlaylists()
    was being used before playlists were added, and seemingly didn't affect
    LB playlists either as the null playlist ID would cause the check
    functions to think the bogus playlists had already been handled due to
    the platform entries in Parents.xml
    oblivioncth committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    73c6c42 View commit details
    Browse the repository at this point in the history
  3. Set reasonable max for LB free index tracker

    Previous max of -1 was a leftover from the previous implementation of
    Qx::FreeIndexTracker who's index type was templated, so -1 represented a
    reasonable max (likely 32-bit integer limit); however, now that the
    tracker uses quint64 for indexing, -1 was interpreted as the maximum
    value for 64-bit integers and caused allocaiton of its internal bit-
    array to fail due to absurd size requirements.
    
    This was undiscovered due to the previous playlist bugs.
    oblivioncth committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    91b6068 View commit details
    Browse the repository at this point in the history
  4. Fix LB DB index reservation for existing playlist games

    Accidentally was calling release() instead of reserve().
    oblivioncth committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    e6ad5f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. LB: Use modified playlist ID cache directly

    No need to store as a QHash with the playlist name as the key since the
    name is not needed. This also avoids the awkwardness that is the
    conversion between the original playlist name and the translated name,
    specific to LB. Before, playlists with names that differed between their
    original and translated names were not being added to the Flashpoint
    platform category as the keys in the hash were the pre-translated names,
    while the list checked against at the end were the translated names.
    oblivioncth committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c81ba21 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #40 from oblivioncth/bugfix/lb_playlist_category

    Fix some playlists not being included under the Flashpoint Platform Category in LaunchBox
    oblivioncth authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    340d962 View commit details
    Browse the repository at this point in the history
  3. Distinguish between modified docs and deleted docs

    Frontends often use modifiedPlatforms()/modifiedPlaylists() to check
    which Platforms/Playlists were affected by the important and need to be
    taken into account by other parts of the frontend; however, this
    obviously only applies if the doc was stricly modified and not outright
    removed, which can happen if the commited modified doc is empty.
    
    This change ensures that only modified docs that remain will be part of
    the modified list.
    oblivioncth committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c0e4d25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    518315a View commit details
    Browse the repository at this point in the history
  5. Make translateDocName() public

    Needed for some ImportWorker tasks
    oblivioncth committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    e2456d4 View commit details
    Browse the repository at this point in the history
  6. Don't use FP's favorities icon

    LB, the only platform that supports them currently, already has its own.
    Will need to revisit this if other platforms that support them are
    added.
    oblivioncth committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    56518be View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e26f858 View commit details
    Browse the repository at this point in the history
  8. Update CLIFp

    oblivioncth committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7a2122e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    88e74a3 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #41 from oblivioncth/feature/platform_playlist_cat…

    …egories
    
    LB: Nest platforms and playlists under their own platform categories
    oblivioncth authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c6a76a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Bump

    oblivioncth committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ac077d7 View commit details
    Browse the repository at this point in the history