Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy artifacts to github-pages #576

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Deploy artifacts to github-pages #576

merged 1 commit into from
Dec 5, 2023

Conversation

AltGr
Copy link
Collaborator

@AltGr AltGr commented Dec 5, 2023

Close #575

@AltGr AltGr merged commit a1ae152 into master Dec 5, 2023
9 checks passed
@erikmd
Copy link
Member

erikmd commented Dec 6, 2023

Hi @AltGr, thanks for working on this!
Unfortunately you merged the PR very quickly before it was tagged with Close #575.

@erikmd
Copy link
Member

erikmd commented Dec 6, 2023

Do you know why the gh-pages branch is not created?

AFAIAC, I'm not familiar with actions/deploy-pages@v3,
I had used peaceiris/actions-gh-pages@v3 instead,
but actions/deploy-pages@v3 looks more "official"...?

@AltGr
Copy link
Collaborator Author

AltGr commented Dec 8, 2023

gh-pages branch is the "old style" way of publishing, now it's purely handled by a Github action IIUC. That was already the way https://ocaml-sf.org/learn-ocaml/ was generated by the way, so I had to extend it to add https://ocaml-sf.org/learn-ocaml/artifacts

Unfortunately you merged the PR very quickly before it was tagged with Close #575.

Technically speaking the PR wasn't enough to solve the issue, I had to experiment with a few patches before I got it working... And GH provides no way that I could find to test on non-master branches

(anyway changelogs are for the actual app, and this doesn't affect it in any way ?)

@erikmd
Copy link
Member

erikmd commented Dec 8, 2023

@AltGr, ah okay, thank you!
I hadn't realized the website was already up at URL https://ocaml-sf.org/learn-ocaml/artifacts/
Thanks a lot for this nice work!

@erikmd
Copy link
Member

erikmd commented Dec 8, 2023

Technically speaking the PR wasn't enough to solve the issue, I had to experiment with a few patches before I got it working... And GH provides no way that I could find to test on non-master branches

Yes you're right, no worries!

(anyway changelogs are for the actual app, and this doesn't affect it in any way ?)

Yes: on the one hand it is not a direct feature of the app,
but on the other hand, it is some ci feature that'll be very useful to users, certainly worth it to document in release notes
like we had done previously:

Anyway, no worries at all! it is always possible to edit releases notes slightly before we merge the release PR.

@erikmd erikmd added the kind: infrastructure CI, build tools, development tools label Dec 11, 2023
@erikmd erikmd added this to the learn-ocaml 1.0.0 milestone Dec 11, 2023
@erikmd erikmd added the kind: enhancement Enhancement to an existing user-facing feature. label Dec 11, 2023
@erikmd erikmd deleted the deploy-artifacts branch February 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature. kind: infrastructure CI, build tools, development tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: deploy static artifacts from master in GitHub Pages
2 participants