[new release] x509 (0.16.5)

[hannesm]

Public Key Infrastructure (RFC 5280, PKCS) purely in OCaml

• Project page: https://github.com/mirleft/ocaml-x509
• Documentation: https://mirleft.github.io/ocaml-x509/doc

CHANGES:

• Always embed local_key_id in PKCS12 bags (reported WIP: Add PKCS12 LocalKeyId attribute to bags (openssl and firefox compatibility) mirleft/ocaml-x509#163 by @NightBlues,
  revised and implemented by @hannesm)

[hannesm]

macos tests: I suspect these are still related to the miscompilation of some EC code (of mirage-crypto-ec) in some llvm version on arm64 macos... maybe you could update to the latest llvm there (see mit-plv/fiat-crypto#1606 (comment) and the comments up and down thereof)

[hannesm]

CI failures are unrelated -- either Cancelled (timeout) or OpamSolution.Fetch_fail("Sys_error(\"No space left on device\")") -- so imho good to merge.

[avsm]

Regarding the macOS compilation, could the host compiler perhaps be looked at @mtelvers @tmcgilchrist? #24045 (comment)

Agreed rest looks good, merging!

[tmcgilchrist]

@avsm the compiler version we are running is clang-1403.0.22.14.1, which is the latest Apple provide for this version of macOS. I don't think we should be upgrading beyond that since that is the vendor supported compiler and what a user would get by default. If this package needs an alternate compiler to work on macOS-arm64 then it should be a depext on the homebrew version required.

$ sw_vers 
ProductName:		macOS
ProductVersion:		13.4.1
BuildVersion:		22F82
$ clang --version
Apple clang version 14.0.3 (clang-1403.0.22.14.1)
Target: arm64-apple-darwin22.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin